[KJ] [PATCH] - pxafb should use msleep

[KJ] [PATCH] - pxafb should use msleep

[Chuck Short]

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Hi,

This patch changes pxafb to use msleep.

Signed-of-by: Chuck Short <zulcss@gmail.com>


[-- Attachment #2: pxafb-msleep.patch --]
[-- Type: text/x-patch, Size: 735 bytes --]

diff -Naur linux-source-2.6.12-2.6.11.92.orig/drivers/video/pxafb.c linux-source-2.6.12-2.6.11.92/drivers/video/pxafb.c
--- linux-source-2.6.12-2.6.11.92.orig/drivers/video/pxafb.c	2005-04-21 06:39:57.000000000 -0400
+++ linux-source-2.6.12-2.6.11.92/drivers/video/pxafb.c	2005-05-18 12:39:56.942489336 -0400
@@ -740,14 +740,13 @@
 
 	DPRINTK("Disabling LCD controller\n");
 
-	set_current_state(TASK_UNINTERRUPTIBLE);
 	add_wait_queue(&fbi->ctrlr_wait, &wait);
 
 	LCSR = 0xffffffff;	/* Clear LCD Status Register */
 	LCCR0 &= ~LCCR0_LDM;	/* Enable LCD Disable Done Interrupt */
 	LCCR0 |= LCCR0_DIS;	/* Disable LCD Controller */
 
-	schedule_timeout(20 * HZ / 1000);
+	msleep(20);
 	remove_wait_queue(&fbi->ctrlr_wait, &wait);
 }
 


[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] [PATCH] - pxafb should use msleep

[Chuck Short]

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Hi,

This patch changes pxafb to use msleep.

Signed-of-by: Chuck Short <zulcss@gmail.com>


[-- Attachment #2: pxafb-msleep.patch --]
[-- Type: text/x-patch, Size: 735 bytes --]

diff -Naur linux-source-2.6.12-2.6.11.92.orig/drivers/video/pxafb.c linux-source-2.6.12-2.6.11.92/drivers/video/pxafb.c
--- linux-source-2.6.12-2.6.11.92.orig/drivers/video/pxafb.c	2005-04-21 06:39:57.000000000 -0400
+++ linux-source-2.6.12-2.6.11.92/drivers/video/pxafb.c	2005-05-18 12:39:56.942489336 -0400
@@ -740,14 +740,13 @@
 
 	DPRINTK("Disabling LCD controller\n");
 
-	set_current_state(TASK_UNINTERRUPTIBLE);
 	add_wait_queue(&fbi->ctrlr_wait, &wait);
 
 	LCSR = 0xffffffff;	/* Clear LCD Status Register */
 	LCCR0 &= ~LCCR0_LDM;	/* Enable LCD Disable Done Interrupt */
 	LCCR0 |= LCCR0_DIS;	/* Disable LCD Controller */
 
-	schedule_timeout(20 * HZ / 1000);
+	msleep(20);
 	remove_wait_queue(&fbi->ctrlr_wait, &wait);
 }
 


[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] - pxafb should use msleep

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On 23/05/05 18:30 -0400, Chuck Short wrote:
> Hi,
> 
> This patch changes pxafb to use msleep.
> 
> Signed-of-by: Chuck Short <zulcss@gmail.com>
> 

> diff -Naur linux-source-2.6.12-2.6.11.92.orig/drivers/video/pxafb.c linux-source-2.6.12-2.6.11.92/drivers/video/pxafb.c
> --- linux-source-2.6.12-2.6.11.92.orig/drivers/video/pxafb.c	2005-04-21 06:39:57.000000000 -0400
> +++ linux-source-2.6.12-2.6.11.92/drivers/video/pxafb.c	2005-05-18 12:39:56.942489336 -0400
> @@ -740,14 +740,13 @@
>  
>  	DPRINTK("Disabling LCD controller\n");
>  
> -	set_current_state(TASK_UNINTERRUPTIBLE);
>  	add_wait_queue(&fbi->ctrlr_wait, &wait);
>  
>  	LCSR = 0xffffffff;	/* Clear LCD Status Register */
>  	LCCR0 &= ~LCCR0_LDM;	/* Enable LCD Disable Done Interrupt */
>  	LCCR0 |= LCCR0_DIS;	/* Disable LCD Controller */
>  
> -	schedule_timeout(20 * HZ / 1000);
> +	msleep(20);
>  	remove_wait_queue(&fbi->ctrlr_wait, &wait);

Sorry, but msleep() in not waitqueue friendly, it won't wake_up().


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors