* [PATCH] show swsuspend only on .config where it can compile
@ 2005-05-26 11:16 Olaf Hering
2005-05-26 11:46 ` Pavel Machek
2005-05-26 12:49 ` Romano Giannetti
0 siblings, 2 replies; 4+ messages in thread
From: Olaf Hering @ 2005-05-26 11:16 UTC (permalink / raw)
To: Pavel Machek, Andrew Morton, linux-kernel
show swsuspend only on .config where it can compile.
I got this on PPC32 && SMP
kernel/power/smp.c:24: error: storage size of `ctxt' isn't known
Signed-off-by: Olaf Hering <olh@suse.de>
Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
===================================================================
--- linux-2.6.12-rc5-olh.orig/kernel/power/Kconfig
+++ linux-2.6.12-rc5-olh/kernel/power/Kconfig
@@ -28,7 +28,7 @@ config PM_DEBUG
config SOFTWARE_SUSPEND
bool "Software Suspend (EXPERIMENTAL)"
- depends on EXPERIMENTAL && PM && SWAP
+ depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)
---help---
Enable the possibility of suspending the machine.
It doesn't need APM.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] show swsuspend only on .config where it can compile
2005-05-26 11:16 [PATCH] show swsuspend only on .config where it can compile Olaf Hering
@ 2005-05-26 11:46 ` Pavel Machek
2005-05-26 12:49 ` Romano Giannetti
1 sibling, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2005-05-26 11:46 UTC (permalink / raw)
To: Olaf Hering; +Cc: Pavel Machek, Andrew Morton, linux-kernel
On Čt 26-05-05 13:16:14, Olaf Hering wrote:
> show swsuspend only on .config where it can compile.
> I got this on PPC32 && SMP
>
> kernel/power/smp.c:24: error: storage size of `ctxt' isn't known
>
> Signed-off-by: Olaf Hering <olh@suse.de>
Thanks, applied. Also swsusp is pretty stable now, so I'll mark it as
stable.
Pavel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] show swsuspend only on .config where it can compile
2005-05-26 11:16 [PATCH] show swsuspend only on .config where it can compile Olaf Hering
2005-05-26 11:46 ` Pavel Machek
@ 2005-05-26 12:49 ` Romano Giannetti
2005-05-26 13:55 ` Pavel Machek
1 sibling, 1 reply; 4+ messages in thread
From: Romano Giannetti @ 2005-05-26 12:49 UTC (permalink / raw)
To: Olaf Hering; +Cc: Pavel Machek, Andrew Morton, linux-kernel
On Thu, May 26, 2005 at 01:16:14PM +0200, Olaf Hering wrote:
> show swsuspend only on .config where it can compile.
> I got this on PPC32 && SMP
>
> kernel/power/smp.c:24: error: storage size of `ctxt' isn't known
>
> Signed-off-by: Olaf Hering <olh@suse.de>
>
> Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
> ===================================================================
> --- linux-2.6.12-rc5-olh.orig/kernel/power/Kconfig
> +++ linux-2.6.12-rc5-olh/kernel/power/Kconfig
> @@ -28,7 +28,7 @@ config PM_DEBUG
>
> config SOFTWARE_SUSPEND
> bool "Software Suspend (EXPERIMENTAL)"
> - depends on EXPERIMENTAL && PM && SWAP
> + depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)
Shouldn't be ...&& ( (X86 && SMP) || (FVR || PPC32 || X86) && !SMP ) ?
and maybe
EXPERIMENTAL && PM && SWAP && ( X86 || ((FVR || PPC32) && !SMP) )
is clearer?
--
Romano Giannetti - Univ. Pontificia Comillas (Madrid, Spain)
Electronic Engineer - phone +34 915 422 800 ext 2416 fax +34 915 596 569
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] show swsuspend only on .config where it can compile
2005-05-26 12:49 ` Romano Giannetti
@ 2005-05-26 13:55 ` Pavel Machek
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2005-05-26 13:55 UTC (permalink / raw)
To: romano, Olaf Hering, Pavel Machek, Andrew Morton, linux-kernel
Hi!
> > kernel/power/smp.c:24: error: storage size of `ctxt' isn't known
> >
> > Signed-off-by: Olaf Hering <olh@suse.de>
> >
> > Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
> > ===================================================================
> > --- linux-2.6.12-rc5-olh.orig/kernel/power/Kconfig
> > +++ linux-2.6.12-rc5-olh/kernel/power/Kconfig
> > @@ -28,7 +28,7 @@ config PM_DEBUG
> >
> > config SOFTWARE_SUSPEND
> > bool "Software Suspend (EXPERIMENTAL)"
> > - depends on EXPERIMENTAL && PM && SWAP
> > + depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)
>
> Shouldn't be ...&& ( (X86 && SMP) || (FVR || PPC32 || X86) && !SMP )
> > ?
Missing parenthesis added, thanks.
Pavel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-05-26 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-26 11:16 [PATCH] show swsuspend only on .config where it can compile Olaf Hering
2005-05-26 11:46 ` Pavel Machek
2005-05-26 12:49 ` Romano Giannetti
2005-05-26 13:55 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.