From: Arnd Bergmann <arnd@arndb.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Fix gcc4 warning,
Date: Thu, 26 May 2005 21:07:36 +0000 [thread overview]
Message-ID: <200505262307.37233.arnd@arndb.de> (raw)
In-Reply-To: <428E3224.8030307@cs.pdx.edu>
On Middeweken 25 Mai 2005 21:18, Jesse Millan wrote:
> Your right, it could go either way. Arnd Bergmann had posted earlier and
> said that it would be better to make the change in the function itself.
> I took that advice.
I think what Mark was suggesting is to initialize the parameters at the
start of the inner function (asn1_length_decode), which makes perfect
sense to me, at least in this particular case.
What you should not do is initialize it in the calling function, because
then you defeat gcc's ability to warn you about real uninitialized uses
of the local variables in that function.
Arnd <><
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-05-26 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-20 18:53 [KJ] [PATCH] Fix gcc4 warning, Jesse Millan
2005-05-20 19:41 ` Alexey Dobriyan
2005-05-22 9:25 ` Arnd Bergmann
2005-05-23 1:05 ` Arnd Bergmann
2005-05-24 4:52 ` Jesse Millan
2005-05-24 4:56 ` Jesse Millan
2005-05-25 6:09 ` Jesse Millan
2005-05-25 22:41 ` Jesse Millan
2005-05-26 21:07 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505262307.37233.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.