From: Jesse Millan <jessem@cs.pdx.edu>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] Fix gcc4 warning,
Date: Fri, 20 May 2005 18:53:24 +0000 [thread overview]
Message-ID: <428E3224.8030307@cs.pdx.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
This patch eliminates the warning that is generated when passing an
uninitialized variable to a function, and in that function it 'looks'
like you may read the contents.
In this case, the address of a local variable 'idx' is passed to the
function bvec_alloc_bs(). Inside bvec_alloc_bs(), it is possible that
no value will be assigned to idx, in which case the function immediately
returns null and does not go on to read it. Human eyes can see that its
safe. Initializing it doen not hurt and it gets rid of the compiler warning.
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 423 bytes --]
Signed-off-by: Jesse Millan <jessem@cs.pdx.edu>
--- linux-2.6.12-rc4/fs/bio.c~ 2005-05-20 11:24:39.163613256 -0700
+++ linux-2.6.12-rc4/fs/bio.c 2005-05-20 11:25:35.242185201 -0700
@@ -159,7 +159,7 @@ struct bio *bio_alloc_bioset(unsigned in
bio_init(bio);
if (likely(nr_iovecs)) {
- unsigned long idx;
+ unsigned long idx = 0;
bvl = bvec_alloc_bs(gfp_mask, nr_iovecs, &idx, bs);
if (unlikely(!bvl)) {
[-- Attachment #3: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-05-20 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-20 18:53 Jesse Millan [this message]
2005-05-20 19:41 ` [KJ] [PATCH] Fix gcc4 warning, Alexey Dobriyan
2005-05-22 9:25 ` Arnd Bergmann
2005-05-23 1:05 ` Arnd Bergmann
2005-05-24 4:52 ` Jesse Millan
2005-05-24 4:56 ` Jesse Millan
2005-05-25 6:09 ` Jesse Millan
2005-05-25 22:41 ` Jesse Millan
2005-05-26 21:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428E3224.8030307@cs.pdx.edu \
--to=jessem@cs.pdx.edu \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.