From: Alexey Dobriyan <adobriyan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] - nicstar gcc 4 warnings
Date: Mon, 30 May 2005 06:17:06 +0000 [thread overview]
Message-ID: <200505301017.06916.adobriyan@gmail.com> (raw)
In-Reply-To: <429A7583.4010201@gmail.com>
On Monday 30 May 2005 06:08, Chuck Short wrote:
> This patch fixes gcc4 warnings when compiling the nicstar driver.
> --- linux-source-2.6.12-2.6.11.93.orig/drivers/atm/nicstar.c
> +++ linux-source-2.6.12-2.6.11.93/drivers/atm/nicstar.c
> static void process_rsq(ns_dev *card)
> {
> - ns_rsqe *previous;
> + ns_rsqe *previous = NULL;
FWIW, this warning is bogus too.
======================================
#define ns_rsqe_valid(ns_rsqep) \
(le32_to_cpu((ns_rsqep)->word_4) & NS_RSQE_VALID)
static void process_rsq(ns_dev *card)
{
ns_rsqe *previous;
if (!ns_rsqe_valid(card->rsq.next))
return;
/* now ns_rsqe_valid(card->rsq.next) = true */
while (ns_rsqe_valid(card->rsq.next)) {
dequeue_rx(card, card->rsq.next);
ns_rsqe_init(card->rsq.next);
/* previous is initialized */
previous = card->rsq.next;
if (card->rsq.next = card->rsq.last)
card->rsq.next = card->rsq.base;
else
card->rsq.next++;
}
writel((((u32) previous) - ((u32) card->rsq.base)),
card->membase + RSQH);
}
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-05-30 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-30 2:08 [KJ] [PATCH] - nicstar gcc 4 warnings Chuck Short
2005-05-30 6:17 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505301017.06916.adobriyan@gmail.com \
--to=adobriyan@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.