[KJ] [PATCH] - nicstar gcc 4 warnings

[KJ] [PATCH] - nicstar gcc 4 warnings

[Chuck Short]

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

Hi,

This patch fixes gcc4 warnings when compiling the nicstar driver.

Signed-off by: Chuck Short <zulcss@gmail.com>


[-- Attachment #2: atm_nicstar_gcc4-warnings.patch --]
[-- Type: text/x-patch, Size: 485 bytes --]

diff -Naur linux-source-2.6.12-2.6.11.93.orig/drivers/atm/nicstar.c linux-source-2.6.12-2.6.11.93/drivers/atm/nicstar.c
--- linux-source-2.6.12-2.6.11.93.orig/drivers/atm/nicstar.c	2005-04-07 08:57:14.000000000 -0400
+++ linux-source-2.6.12-2.6.11.93/drivers/atm/nicstar.c	2005-05-29 14:34:12.123970048 -0400
@@ -2111,7 +2111,7 @@
 
 static void process_rsq(ns_dev *card)
 {
-   ns_rsqe *previous;
+   ns_rsqe *previous = NULL;
 
    if (!ns_rsqe_valid(card->rsq.next))
       return;

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] - nicstar gcc 4 warnings

[Alexey Dobriyan]

On Monday 30 May 2005 06:08, Chuck Short wrote:
> This patch fixes gcc4 warnings when compiling the nicstar driver.

> --- linux-source-2.6.12-2.6.11.93.orig/drivers/atm/nicstar.c
> +++ linux-source-2.6.12-2.6.11.93/drivers/atm/nicstar.c

> static void process_rsq(ns_dev *card)
> {
> -   ns_rsqe *previous;
> +   ns_rsqe *previous = NULL;

FWIW, this warning is bogus too.
======================================
#define ns_rsqe_valid(ns_rsqep) \
        (le32_to_cpu((ns_rsqep)->word_4) & NS_RSQE_VALID)

static void process_rsq(ns_dev *card)
{
	ns_rsqe *previous;

	if (!ns_rsqe_valid(card->rsq.next))
		return;
	/* now ns_rsqe_valid(card->rsq.next) = true */
	while (ns_rsqe_valid(card->rsq.next)) {
		dequeue_rx(card, card->rsq.next);
		ns_rsqe_init(card->rsq.next);
		/* previous is initialized */
		previous = card->rsq.next;
		if (card->rsq.next = card->rsq.last)
			card->rsq.next = card->rsq.base;
		else
			card->rsq.next++;
	}
	writel((((u32) previous) - ((u32) card->rsq.base)),
			card->membase + RSQH);
}
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors