From: Pavel Machek <pavel@ucw.cz>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-pm <linux-pm@lists.osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] Don't explode on swsusp failure to find swap
Date: Wed, 1 Jun 2005 11:29:06 +0200 [thread overview]
Message-ID: <20050601092906.GD6693@elf.ucw.cz> (raw)
In-Reply-To: <1117608759.10003.7.camel@linux-hp.sh.intel.com>
[-- Attachment #1: Type: text/plain, Size: 753 bytes --]
Hi!
> > More specifically, arch suspend calls swsusp_save().
> >
> > It fails and returns the error to the arch asm code, which itself
> > returns it to it's caller swsusp_suspend(), which does that:
> >
> > if ((error = swsusp_arch_suspend()))
> > swsusp_free();
> I encounter a similar issue, when swsusp_swap_check failed.
> It seems the swsusp_free isn't required in the failure case,
> suspend_prepare_image has correctly handled the failure case to me.
> Other arch? I wonder why swsusp_free is called after device_power_down
> failed as well. No pages are allocated before device_power_down.
Agreed, its wrong. Also there's no reason for the swap check to be
called (even indirectly) from arch code...
Pavel
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-pm <linux-pm@lists.osdl.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [linux-pm] Re: [PATCH] Don't explode on swsusp failure to find swap
Date: Wed, 1 Jun 2005 11:29:06 +0200 [thread overview]
Message-ID: <20050601092906.GD6693@elf.ucw.cz> (raw)
In-Reply-To: <1117608759.10003.7.camel@linux-hp.sh.intel.com>
Hi!
> > More specifically, arch suspend calls swsusp_save().
> >
> > It fails and returns the error to the arch asm code, which itself
> > returns it to it's caller swsusp_suspend(), which does that:
> >
> > if ((error = swsusp_arch_suspend()))
> > swsusp_free();
> I encounter a similar issue, when swsusp_swap_check failed.
> It seems the swsusp_free isn't required in the failure case,
> suspend_prepare_image has correctly handled the failure case to me.
> Other arch? I wonder why swsusp_free is called after device_power_down
> failed as well. No pages are allocated before device_power_down.
Agreed, its wrong. Also there's no reason for the swap check to be
called (even indirectly) from arch code...
Pavel
next prev parent reply other threads:[~2005-06-01 9:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-31 7:13 [PATCH] Don't explode on swsusp failure to find swap Benjamin Herrenschmidt
2005-05-31 7:13 ` Benjamin Herrenschmidt
2005-05-31 10:36 ` Pavel Machek
2005-05-31 10:36 ` Pavel Machek
2005-05-31 14:45 ` Benjamin Herrenschmidt
2005-05-31 14:45 ` Benjamin Herrenschmidt
2005-05-31 23:50 ` Benjamin Herrenschmidt
2005-05-31 23:50 ` Benjamin Herrenschmidt
2005-06-01 6:52 ` Shaohua Li
2005-06-01 6:52 ` [linux-pm] " Shaohua Li
2005-06-01 9:29 ` Pavel Machek [this message]
2005-06-01 9:29 ` Pavel Machek
2005-06-01 9:27 ` Pavel Machek
2005-06-01 9:27 ` Pavel Machek
2005-06-01 19:20 ` [linux-pm] " Rafael J. Wysocki
2005-06-01 20:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050601092906.GD6693@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.