From: Greg KH <greg@kroah.com>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH][1/5] RapidIO support: core
Date: Fri, 3 Jun 2005 00:20:27 -0700 [thread overview]
Message-ID: <20050603072027.GD30292@kroah.com> (raw)
In-Reply-To: <20050602140359.B24818@cox.net>
On Thu, Jun 02, 2005 at 02:03:59PM -0700, Matt Porter wrote:
> +static struct device rio_bus = {
> + .bus_id = "rapidio",
> +};
Why do you need this device? You shouldn't have a static struct device
to start with. Or you just don't like having your root rio device
showing up in /sys/devices/ ?
If so, just create a kobject and put it there, and then base your
devices off of it, no need for a real device.
Oh wait, that's what the platform and system code does. bah,
nevermind...
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH][1/5] RapidIO support: core
Date: Fri, 3 Jun 2005 00:20:27 -0700 [thread overview]
Message-ID: <20050603072027.GD30292@kroah.com> (raw)
In-Reply-To: <20050602140359.B24818@cox.net>
On Thu, Jun 02, 2005 at 02:03:59PM -0700, Matt Porter wrote:
> +static struct device rio_bus = {
> + .bus_id = "rapidio",
> +};
Why do you need this device? You shouldn't have a static struct device
to start with. Or you just don't like having your root rio device
showing up in /sys/devices/ ?
If so, just create a kobject and put it there, and then base your
devices off of it, no need for a real device.
Oh wait, that's what the platform and system code does. bah,
nevermind...
thanks,
greg k-h
next prev parent reply other threads:[~2005-06-03 7:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-02 21:03 [PATCH][1/5] RapidIO support: core Matt Porter
2005-06-02 21:12 ` [PATCH][2/5] RapidIO support: core includes Matt Porter
2005-06-02 21:19 ` [PATCH][3/5] RapidIO support: enumeration Matt Porter
2005-06-02 21:25 ` [PATCH][4/5] RapidIO support: ppc32 Matt Porter
2005-06-02 21:34 ` [PATCH][5/5] RapidIO support: net driver over messaging Matt Porter
2005-06-02 21:34 ` Matt Porter
2005-06-02 22:05 ` Stephen Hemminger
2005-06-02 22:05 ` Stephen Hemminger
2005-06-03 22:43 ` Matt Porter
2005-06-03 22:43 ` Matt Porter
2005-06-03 7:11 ` [PATCH][1/5] RapidIO support: core Greg KH
2005-06-03 7:11 ` Greg KH
2005-06-03 21:24 ` Matt Porter
2005-06-03 21:24 ` Matt Porter
2005-06-03 7:20 ` Greg KH [this message]
2005-06-03 7:20 ` Greg KH
2005-06-03 21:35 ` Matt Porter
2005-06-03 21:35 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050603072027.GD30292@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=mporter@kernel.crashing.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.