From: Grant Grundler <grundler@parisc-linux.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: parisc-linux@parisc-linux.org, Matthew Wilcox <matthew@wil.cx>
Subject: [parisc-linux] Re: [patch] spinlock consolidation, v2
Date: Mon, 6 Jun 2005 09:12:32 -0600 [thread overview]
Message-ID: <20050606151232.GA24437@colo.lackof.org> (raw)
In-Reply-To: <20050606073627.GA10387@elte.hu>
On Mon, Jun 06, 2005 at 09:36:27AM +0200, Ingo Molnar wrote:
> > I've adapted parisc-linux to this patch and put my changes into
> > a patch that goes on top of Ingo's.
>
> i'm wondering, is the conversion to raw_spinlock_t absolutely necessary
> to get a working PARISC kernel?
No. They were regular spinlocks before too. But there was a pretty
ugly set of interdependencies between asm/system.h, spinlock.h,
atomic.h, and bitops.h.
The cleanup necessary might be alot more baggage than you want
to carry around for this patch.
> I feel a bit uneasy about using the raw
> spinlocks directly - they were not intended to be used like that, for
> the time being. Right now they are internal types.
They are arch specific types (asm/spinlock_types.h) and
I'm only using raw_spinlock_t in arch specific code.
> You should be able to
> use spinlock_types.h just as much to simplify your include file
> dependencies. (as long as you use the spinlock APIs only in .c files)
I'll take another quick look
and see where the circular dependencies are now.
thanks,
grant
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
next prev parent reply other threads:[~2005-06-06 15:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 17:31 [parisc-linux] [mingo@elte.hu: [patch] spinlock consolidation, v2] Matthew Wilcox
2005-06-04 11:55 ` Joel Soete
2005-06-04 18:03 ` Grant Grundler
2005-06-05 19:13 ` Joel Soete
2005-06-06 6:05 ` [parisc-linux] Re: [patch] spinlock consolidation, v2 Grant Grundler
2005-06-06 7:36 ` Ingo Molnar
2005-06-06 15:12 ` Grant Grundler [this message]
2005-06-06 16:31 ` Ingo Molnar
2005-06-06 17:55 ` Grant Grundler
[not found] ` <20050606175029.GC24437@colo.lackof.org>
2005-06-12 6:49 ` Ingo Molnar
2005-06-12 7:25 ` Grant Grundler
2005-06-12 7:34 ` Ingo Molnar
2005-06-13 6:29 ` Grant Grundler
2005-06-13 7:44 ` Ingo Molnar
2005-06-13 18:39 ` Grant Grundler
2005-06-21 11:22 ` Ingo Molnar
[not found] <20050607180315.GH29220@colo.lackof.org>
[not found] ` <4282FEEC0000AB95@mail-3-bnl.tiscali.it>
2005-06-08 16:05 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050606151232.GA24437@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=parisc-linux@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.