All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: parisc-linux@parisc-linux.org, Matthew Wilcox <matthew@wil.cx>
Subject: [parisc-linux] Re: [patch] spinlock consolidation, v2
Date: Mon, 13 Jun 2005 00:29:38 -0600	[thread overview]
Message-ID: <20050613062938.GD21766@colo.lackof.org> (raw)
In-Reply-To: <20050612073453.GA7718@elte.hu>

On Sun, Jun 12, 2005 at 09:34:53AM +0200, Ingo Molnar wrote:
> 
> * Grant Grundler <grundler@parisc-linux.org> wrote:
> 
> > > thanks. I'm still wondering about the fundamental question though: why 
> > > doesnt the box boot without your patch?
> > 
> > Did you mean to ask: Why doesn't the kernel build w/o my patch?
> 
> ah, ok. If that's the case, then the main problem is that i've added 
> #include <asm/atomic.h> to linux/spinlock.h? 

Hrmm...I'm not sure I'd call that a "problem".
linux/spinlock.h uses atomic_t and following current rules,
it should include some version of atomic.h to get a definition
of atomic_t.

> If you remove that
> include from linux/spinlock.h and if you hack atomic_dec_and_lock to not 
> use atomic_t but void *, does it build fine?

I remove the include but continued to use "atomic_t" anyway.
That built too. :^)

Oh, sorry. I just realized that's still with my patch in place.
Tomorrow I'll back out my patch and see if it still builds.

BTW, I do not like "void *" if we can (and should) use a special typedef.

thanks,
grant
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

  reply	other threads:[~2005-06-13  6:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-03 17:31 [parisc-linux] [mingo@elte.hu: [patch] spinlock consolidation, v2] Matthew Wilcox
2005-06-04 11:55 ` Joel Soete
2005-06-04 18:03   ` Grant Grundler
2005-06-05 19:13     ` Joel Soete
2005-06-06  6:05 ` [parisc-linux] Re: [patch] spinlock consolidation, v2 Grant Grundler
2005-06-06  7:36   ` Ingo Molnar
2005-06-06 15:12     ` Grant Grundler
2005-06-06 16:31       ` Ingo Molnar
2005-06-06 17:55         ` Grant Grundler
     [not found]     ` <20050606175029.GC24437@colo.lackof.org>
2005-06-12  6:49       ` Ingo Molnar
2005-06-12  7:25         ` Grant Grundler
2005-06-12  7:34           ` Ingo Molnar
2005-06-13  6:29             ` Grant Grundler [this message]
2005-06-13  7:44               ` Ingo Molnar
2005-06-13 18:39                 ` Grant Grundler
2005-06-21 11:22                   ` Ingo Molnar
     [not found] <20050607180315.GH29220@colo.lackof.org>
     [not found] ` <4282FEEC0000AB95@mail-3-bnl.tiscali.it>
2005-06-08 16:05   ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050613062938.GD21766@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=parisc-linux@parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.