* [PATCH] x64-vmxassist-fix.patch
@ 2005-06-10 22:09 Arun Sharma
2005-06-11 5:39 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Arun Sharma @ 2005-06-10 22:09 UTC (permalink / raw)
To: Ian Pratt, Keir Fraser; +Cc: xen-devel
Fix 64 bit build.
Signed-off-by: Nitin Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Arun Sharma <arun.sharma@intel.com>
--- a/tools/firmware/vmxassist/head.S Fri Jun 10 17:48:42 2005
+++ b/tools/firmware/vmxassist/head.S Fri Jun 10 15:08:15 2005
@@ -135,7 +135,7 @@
.align 4
.globl halt
halt:
- pushl $halt_msg
+ push $halt_msg
call printf
#ifdef TEST
movw $0x8A00, %dx
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] x64-vmxassist-fix.patch
2005-06-10 22:09 [PATCH] x64-vmxassist-fix.patch Arun Sharma
@ 2005-06-11 5:39 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2005-06-11 5:39 UTC (permalink / raw)
To: Arun Sharma; +Cc: xen-devel, Ian Pratt
On 10 Jun 2005, at 23:09, Arun Sharma wrote:
> Fix 64 bit build.
>
> Signed-off-by: Nitin Kamble <nitin.a.kamble@intel.com>
> Signed-off-by: Arun Sharma <arun.sharma@intel.com>
Surely the correct fix is to put a .code32 at the top of the file? The
vmxassist stuff should run in 32-bit protected mode: long mode doesn't
necessarily support VM86 mode (not on amd chips I believe).
I think the checked-in fix is benign but not the right run-time fix. :-)
-- Keir
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-06-11 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-10 22:09 [PATCH] x64-vmxassist-fix.patch Arun Sharma
2005-06-11 5:39 ` Keir Fraser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.