All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh-l3A5Bk7waGM@public.gmane.org>
To: len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	ak-l3A5Bk7waGM@public.gmane.org
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 04/04] PCI: let AMD boxes use MMCONFIG
Date: Tue, 14 Jun 2005 22:33:16 -0700	[thread overview]
Message-ID: <20050615053316.GE23394@kroah.com> (raw)
In-Reply-To: <20050615053214.GD23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>


Now that we parse and handle the MCFG table properly, we can hopefully
remove the AMD check and let those boxes use MMCONFIG.

Note, this needs _lots_ of testing on lots of boxes before going to
mainline...

Signed-off-by: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>


---
 arch/i386/pci/mmconfig.c   |    7 -------
 arch/x86_64/pci/mmconfig.c |    7 -------
 2 files changed, 14 deletions(-)

--- gregkh-2.6.orig/arch/i386/pci/mmconfig.c	2005-06-14 22:07:52.000000000 -0700
+++ gregkh-2.6/arch/i386/pci/mmconfig.c	2005-06-14 22:09:16.000000000 -0700
@@ -127,13 +127,6 @@
 	    (pci_mmcfg_config[0].base_address == 0))
 		goto out;
 
-	/* Kludge for now. Don't use mmconfig on AMD systems because
-	   those have some busses where mmconfig doesn't work,
-	   and we don't parse ACPI MCFG well enough to handle that. 
-	   Remove when proper handling is added. */
-	if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
-		goto out; 
-
 	printk(KERN_INFO "PCI: Using MMCONFIG\n");
 	raw_pci_ops = &pci_mmcfg;
 	pci_probe = (pci_probe & ~PCI_PROBE_MASK) | PCI_PROBE_MMCONF;
--- gregkh-2.6.orig/arch/x86_64/pci/mmconfig.c	2005-06-14 22:08:44.000000000 -0700
+++ gregkh-2.6/arch/x86_64/pci/mmconfig.c	2005-06-14 22:09:11.000000000 -0700
@@ -111,13 +111,6 @@
 	    (pci_mmcfg_config[0].base_address == 0))
 		return 0;
 
-	/* Kludge for now. Don't use mmconfig on AMD systems because
-	   those have some busses where mmconfig doesn't work,
-	   and we don't parse ACPI MCFG well enough to handle that. 
-	   Remove when proper handling is added. */
-	if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
-		return 0; 
-
 	/* RED-PEN i386 doesn't do _nocache right now */
 	pci_mmcfg_virt = kmalloc(sizeof(*pci_mmcfg_virt) * pci_mmcfg_config_num, GFP_KERNEL);
 	if (pci_mmcfg_virt == NULL) {


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: len.brown@intel.com, ak@suse.de
Cc: acpi-devel@lists.sourceforge.net,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: [PATCH 04/04] PCI: let AMD boxes use MMCONFIG
Date: Tue, 14 Jun 2005 22:33:16 -0700	[thread overview]
Message-ID: <20050615053316.GE23394@kroah.com> (raw)
In-Reply-To: <20050615053214.GD23394@kroah.com>


Now that we parse and handle the MCFG table properly, we can hopefully
remove the AMD check and let those boxes use MMCONFIG.

Note, this needs _lots_ of testing on lots of boxes before going to
mainline...

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


---
 arch/i386/pci/mmconfig.c   |    7 -------
 arch/x86_64/pci/mmconfig.c |    7 -------
 2 files changed, 14 deletions(-)

--- gregkh-2.6.orig/arch/i386/pci/mmconfig.c	2005-06-14 22:07:52.000000000 -0700
+++ gregkh-2.6/arch/i386/pci/mmconfig.c	2005-06-14 22:09:16.000000000 -0700
@@ -127,13 +127,6 @@
 	    (pci_mmcfg_config[0].base_address == 0))
 		goto out;
 
-	/* Kludge for now. Don't use mmconfig on AMD systems because
-	   those have some busses where mmconfig doesn't work,
-	   and we don't parse ACPI MCFG well enough to handle that. 
-	   Remove when proper handling is added. */
-	if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
-		goto out; 
-
 	printk(KERN_INFO "PCI: Using MMCONFIG\n");
 	raw_pci_ops = &pci_mmcfg;
 	pci_probe = (pci_probe & ~PCI_PROBE_MASK) | PCI_PROBE_MMCONF;
--- gregkh-2.6.orig/arch/x86_64/pci/mmconfig.c	2005-06-14 22:08:44.000000000 -0700
+++ gregkh-2.6/arch/x86_64/pci/mmconfig.c	2005-06-14 22:09:11.000000000 -0700
@@ -111,13 +111,6 @@
 	    (pci_mmcfg_config[0].base_address == 0))
 		return 0;
 
-	/* Kludge for now. Don't use mmconfig on AMD systems because
-	   those have some busses where mmconfig doesn't work,
-	   and we don't parse ACPI MCFG well enough to handle that. 
-	   Remove when proper handling is added. */
-	if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
-		return 0; 
-
 	/* RED-PEN i386 doesn't do _nocache right now */
 	pci_mmcfg_virt = kmalloc(sizeof(*pci_mmcfg_virt) * pci_mmcfg_config_num, GFP_KERNEL);
 	if (pci_mmcfg_virt == NULL) {

  parent reply	other threads:[~2005-06-15  5:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-15  5:29 [PATCH 00/04] PCI: add proper MCFG support to let AMD boxes support MMCONFIG Greg KH
2005-06-15  5:29 ` Greg KH
     [not found] ` <20050615052916.GA23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2005-06-15  5:30   ` [PATCH 01/04] PCI: add proper MCFG table parsing to ACPI core Greg KH
2005-06-15  5:30     ` Greg KH
     [not found]     ` <20050615053031.GB23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2005-06-15  5:31       ` [PATCH 02/04] PCI: use the MCFG table to properly access pci devices (i386) Greg KH
2005-06-15  5:31         ` Greg KH
     [not found]         ` <20050615053120.GC23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2005-06-15  5:32           ` [PATCH 03/04] PCI: use the MCFG table to properly access pci devices (x86-64) Greg KH
2005-06-15  5:32             ` Greg KH
     [not found]             ` <20050615053214.GD23394-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2005-06-15  5:33               ` Greg KH [this message]
2005-06-15  5:33                 ` [PATCH 04/04] PCI: let AMD boxes use MMCONFIG Greg KH
2005-06-16 22:34               ` [PATCH 03/04] PCI: use the MCFG table to properly access pci devices (x86-64) Rajesh Shah
2005-06-16 22:34                 ` Rajesh Shah
     [not found]                 ` <20050616153404.B5337-39QZ/XbsZ5/mO6KZMuUCQVaTQe2KTcn/@public.gmane.org>
2005-06-16 22:42                   ` Greg KH
2005-06-16 22:42                     ` Greg KH
     [not found]                     ` <20050616224223.GA13619-l3A5Bk7waGM@public.gmane.org>
2005-06-16 23:00                       ` Andi Kleen
2005-06-16 23:00                         ` Andi Kleen
2005-06-16 23:49                         ` Brian Gerst
2005-06-17  1:15                         ` Rajesh Shah
2005-06-15  9:48         ` [PATCH 02/04] PCI: use the MCFG table to properly access pci devices (i386) Andi Kleen
     [not found]           ` <20050615094833.GB11898-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2005-06-15 17:31             ` Jeff Garzik
2005-06-15 17:31               ` Jeff Garzik
2005-06-15 17:54           ` Greg KH
     [not found]             ` <20050615175447.GA29138-l3A5Bk7waGM@public.gmane.org>
2005-06-15 18:23               ` Andi Kleen
2005-06-15 18:23                 ` Andi Kleen
     [not found]                 ` <20050615182346.GQ11898-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2005-06-15 18:35                   ` Greg KH
2005-06-15 18:35                     ` Greg KH
     [not found]                     ` <20050615183547.GA29587-l3A5Bk7waGM@public.gmane.org>
2005-06-15 19:03                       ` Andi Kleen
2005-06-15 19:03                         ` Andi Kleen
2005-06-15 20:21                         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050615053316.GE23394@kroah.com \
    --to=gregkh-l3a5bk7wagm@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=ak-l3A5Bk7waGM@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.