Re: rmedigicontrol error w/ 2.6.11 based kernels

Re: rmedigicontrol error w/ 2.6.11 based kernels

[Martin Langer]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

On Fri, Jun 17, 2005 at 01:21:48AM -0400, Dave Maley wrote:
> Hello.  I've been happily using rmedigicontrol for a while now (thanks
> for the great app) but have run into a problem when running 2.6.11 based
> kernels.  My audio workstation runs Fedora Core 3 and w/ the 2.6.9 and
> 2.6.10 based kernels rmedigicontrol works great.  However when I run 1
> of the 2.6.11 based kernels I get this error:
> 
> [dave@homer DOWNLOADS]$ rmedigicontrol
> rmedigicontrol: control.c:1686: snd_ctl_elem_info_get_items: Assertion
> `obj->type == SND_CTL_ELEM_TYPE_ENUMERATED' failed.
> Aborted

There was a change in the mixer (enumerates) and I forgot to change
rmedigicontrol, too. But this patch removes 
"snd_ctl_elem_value_get_enumerated()" for the rme32/rme96 cards now.
The patch is only tested with a rme32 card here.

Signed-off-by: Martin Langer <martin-langer@gmx.de>


martin

[-- Attachment #2: rmedigicontrol.patch --]
[-- Type: text/plain, Size: 1117 bytes --]

Index: rmedigicontrol.c
===================================================================
RCS file: /cvsroot/alsa/alsa-tools/rmedigicontrol/rmedigicontrol.c,v
retrieving revision 1.3
diff -u -r1.3 rmedigicontrol.c
--- rmedigicontrol.c	29 Nov 2004 15:09:16 -0000	1.3
+++ rmedigicontrol.c	17 Jun 2005 18:33:34 -0000
@@ -100,7 +100,7 @@
 	loopback_box=create_loopback_toggle();
 	gtk_box_pack_start(GTK_BOX(col1_box),loopback_box,TRUE,FALSE,0);
 
-       	clock_box=create_enum_elem_radio("Sample Clock Source",&clock_iv);
+	clock_box=create_enum_elem_radio("Sample Clock Source",&clock_iv);
 	gtk_box_pack_start(GTK_BOX(col1_box),clock_box,TRUE,FALSE,0);
 
 	gtk_box_pack_start(GTK_BOX(main_box),col1_box,TRUE,FALSE,8);
@@ -172,8 +172,6 @@
 		r=gtk_radio_button_new_with_label(group,snd_ctl_elem_info_get_item_name(iv->info));
 		group=gtk_radio_button_group(GTK_RADIO_BUTTON(r));
 		gtk_signal_connect(GTK_OBJECT(r),"toggled",GTK_SIGNAL_FUNC(elem_radio_toggled),(gpointer)iv);
-		if(i==snd_ctl_elem_value_get_enumerated(iv->val,0))
-			active=r;
 		gtk_box_pack_start(GTK_BOX(box),r,TRUE,FALSE,0);
 	}
 	if(active)	

Re: rmedigicontrol error w/ 2.6.11 based kernels

[Dave Maley]

On Fri, 2005-06-17 at 20:54 +0200, Martin Langer wrote:
> On Fri, Jun 17, 2005 at 01:21:48AM -0400, Dave Maley wrote:
> > Hello.  I've been happily using rmedigicontrol for a while now (thanks
> > for the great app) but have run into a problem when running 2.6.11 based
> > kernels.  My audio workstation runs Fedora Core 3 and w/ the 2.6.9 and
> > 2.6.10 based kernels rmedigicontrol works great.  However when I run 1
> > of the 2.6.11 based kernels I get this error:
> > 
> > [dave@homer DOWNLOADS]$ rmedigicontrol
> > rmedigicontrol: control.c:1686: snd_ctl_elem_info_get_items: Assertion
> > `obj->type == SND_CTL_ELEM_TYPE_ENUMERATED' failed.
> > Aborted
> 
> There was a change in the mixer (enumerates) and I forgot to change
> rmedigicontrol, too. But this patch removes 
> "snd_ctl_elem_value_get_enumerated()" for the rme32/rme96 cards now.
> The patch is only tested with a rme32 card here.

Thanks much for the quick response.  I'll test this patch w/ my digi96/8
PST card and let you know how things go.

Thanks again!

~Dave



-- 
"A fool and his money are soon parted. I would pay anyone a lot of
money to explain that to me."
-Homer J Simpson



-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click

Re: Re: rmedigicontrol error w/ 2.6.11 based kernels

[Martin Langer]

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Fri, Jun 17, 2005 at 03:04:21PM -0400, Dave Maley wrote:
> On Fri, 2005-06-17 at 20:54 +0200, Martin Langer wrote:
> > On Fri, Jun 17, 2005 at 01:21:48AM -0400, Dave Maley wrote:
> > > Hello.  I've been happily using rmedigicontrol for a while now (thanks
> > > for the great app) but have run into a problem when running 2.6.11 based
> > > kernels.  My audio workstation runs Fedora Core 3 and w/ the 2.6.9 and
> > > 2.6.10 based kernels rmedigicontrol works great.  However when I run 1
> > > of the 2.6.11 based kernels I get this error:
> > > 
> > > [dave@homer DOWNLOADS]$ rmedigicontrol
> > > rmedigicontrol: control.c:1686: snd_ctl_elem_info_get_items: Assertion
> > > `obj->type == SND_CTL_ELEM_TYPE_ENUMERATED' failed.
> > > Aborted
> > 
> > There was a change in the mixer (enumerates) and I forgot to change
> > rmedigicontrol, too. But this patch removes 
> > "snd_ctl_elem_value_get_enumerated()" for the rme32/rme96 cards now.
> > The patch is only tested with a rme32 card here.
> 
> Thanks much for the quick response.  I'll test this patch w/ my digi96/8
> PST card and let you know how things go.

Please try this patch instead. The former one is wrong. Sorry.


martin

[-- Attachment #2: rmedigicontrol.patch --]
[-- Type: text/plain, Size: 1412 bytes --]

Index: rmedigicontrol.c
===================================================================
RCS file: /cvsroot/alsa/alsa-tools/rmedigicontrol/rmedigicontrol.c,v
retrieving revision 1.3
diff -u -r1.3 rmedigicontrol.c
--- rmedigicontrol.c	29 Nov 2004 15:09:16 -0000	1.3
+++ rmedigicontrol.c	17 Jun 2005 21:11:47 -0000
@@ -100,7 +100,7 @@
 	loopback_box=create_loopback_toggle();
 	gtk_box_pack_start(GTK_BOX(col1_box),loopback_box,TRUE,FALSE,0);
 
-       	clock_box=create_enum_elem_radio("Sample Clock Source",&clock_iv);
+	clock_box=create_enum_elem_radio("Sample Clock Source",&clock_iv);
 	gtk_box_pack_start(GTK_BOX(col1_box),clock_box,TRUE,FALSE,0);
 
 	gtk_box_pack_start(GTK_BOX(main_box),col1_box,TRUE,FALSE,8);
@@ -172,14 +172,15 @@
 		r=gtk_radio_button_new_with_label(group,snd_ctl_elem_info_get_item_name(iv->info));
 		group=gtk_radio_button_group(GTK_RADIO_BUTTON(r));
 		gtk_signal_connect(GTK_OBJECT(r),"toggled",GTK_SIGNAL_FUNC(elem_radio_toggled),(gpointer)iv);
-		if(i==snd_ctl_elem_value_get_enumerated(iv->val,0))
+		if(i==snd_ctl_elem_value_get_integer(iv->val,0))
 			active=r;
 		gtk_box_pack_start(GTK_BOX(box),r,TRUE,FALSE,0);
 	}
-	if(active)	
+	if(active)
 		gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(active),TRUE);
 	frame=gtk_frame_new(elem_name);
 	gtk_frame_set_shadow_type(GTK_FRAME(frame),GTK_SHADOW_IN);
 	gtk_container_add(GTK_CONTAINER(frame),box);
 	return frame;
 }
+

Re: Re: rmedigicontrol error w/ 2.6.11 based kernels

[Dave Maley]

On Fri, 2005-06-17 at 23:25 +0200, Martin Langer wrote:
> On Fri, Jun 17, 2005 at 03:04:21PM -0400, Dave Maley wrote:
> > On Fri, 2005-06-17 at 20:54 +0200, Martin Langer wrote:
> > > On Fri, Jun 17, 2005 at 01:21:48AM -0400, Dave Maley wrote:
> > > > Hello.  I've been happily using rmedigicontrol for a while now (thanks
> > > > for the great app) but have run into a problem when running 2.6.11 based
> > > > kernels.  My audio workstation runs Fedora Core 3 and w/ the 2.6.9 and
> > > > 2.6.10 based kernels rmedigicontrol works great.  However when I run 1
> > > > of the 2.6.11 based kernels I get this error:
> > > > 
> > > > [dave@homer DOWNLOADS]$ rmedigicontrol
> > > > rmedigicontrol: control.c:1686: snd_ctl_elem_info_get_items: Assertion
> > > > `obj->type == SND_CTL_ELEM_TYPE_ENUMERATED' failed.
> > > > Aborted
> > > 
> > > There was a change in the mixer (enumerates) and I forgot to change
> > > rmedigicontrol, too. But this patch removes 
> > > "snd_ctl_elem_value_get_enumerated()" for the rme32/rme96 cards now.
> > > The patch is only tested with a rme32 card here.
> > 
> > Thanks much for the quick response.  I'll test this patch w/ my digi96/8
> > PST card and let you know how things go.
> 
> Please try this patch instead. The former one is wrong. Sorry.

No problem at all.  I'll hopefully get this tested once home this
evening ...

Thanks again!

~Dave

> 
> 
> martin
-- 
"A fool and his money are soon parted. I would pay anyone a lot of
money to explain that to me."
-Homer J Simpson



-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click

Re: Re: rmedigicontrol error w/ 2.6.11 based kernels

[Dave Maley]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

> > > There was a change in the mixer (enumerates) and I forgot to change
> > > rmedigicontrol, too. But this patch removes 
> > > "snd_ctl_elem_value_get_enumerated()" for the rme32/rme96 cards now.
> > > The patch is only tested with a rme32 card here.
> > 
> > Thanks much for the quick response.  I'll test this patch w/ my digi96/8
> > PST card and let you know how things go.
> 
> Please try this patch instead. The former one is wrong. Sorry.

That did the trick.  rmedigicontrol's working nicely now w/ my 2.6.11
based kernels.  Thanks much!

The attached patch (essentially a 1-liner) is all I ended up needing to
use.  This was patching the sources from alsa-tools-1.0.9 ...

Thanks again!

Cheers,
Dave

[-- Attachment #2: rme_getinteger.patch --]
[-- Type: text/x-patch, Size: 713 bytes --]

--- rmedigicontrol-1.0.9/rmedigicontrol.c.orig	2005-06-18 13:49:16.000000000 -0400
+++ rmedigicontrol-1.0.9/rmedigicontrol.c	2005-06-18 13:51:06.000000000 -0400
@@ -172,10 +172,11 @@
 		r=gtk_radio_button_new_with_label(group,snd_ctl_elem_info_get_item_name(iv->info));
 		group=gtk_radio_button_group(GTK_RADIO_BUTTON(r));
 		gtk_signal_connect(GTK_OBJECT(r),"toggled",GTK_SIGNAL_FUNC(elem_radio_toggled),(gpointer)iv);
-		if(i==snd_ctl_elem_value_get_enumerated(iv->val,0))
+		if(i==snd_ctl_elem_value_get_integer(iv->val,0))
 			active=r;
 		gtk_box_pack_start(GTK_BOX(box),r,TRUE,FALSE,0);
 	}
+
 	if(active)	
 		gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(active),TRUE);
 	frame=gtk_frame_new(elem_name);