* [patch 6/7] fs/clntlock: remove sleep_on*() usage
@ 2005-06-20 21:57 domen
0 siblings, 0 replies; only message in thread
From: domen @ 2005-06-20 21:57 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, Nishanth Aravamudan, domen
[-- Attachment #1: sleep_on-fs_lockd_clntlock.patch --]
[-- Type: text/plain, Size: 1418 bytes --]
From: Nishanth Aravamudan <nacc@us.ibm.com>
Directly use wait-queues instead of the deprecated
sleep_on_timeout(). Since the sleep in this function is unconditional,
wait_event_timeout() does not appear to be appropriate. Patch is
compile-tested.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
clntlock.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
Index: quilt/fs/lockd/clntlock.c
===================================================================
--- quilt.orig/fs/lockd/clntlock.c
+++ quilt/fs/lockd/clntlock.c
@@ -14,6 +14,7 @@
#include <linux/sunrpc/svc.h>
#include <linux/lockd/lockd.h>
#include <linux/smp_lock.h>
+#include <linux/wait.h>
#define NLMDBG_FACILITY NLMDBG_CLIENT
@@ -47,6 +48,7 @@ static struct nlm_wait * nlm_blocked;
int
nlmclnt_block(struct nlm_host *host, struct file_lock *fl, u32 *statp)
{
+ DEFINE_WAIT(wait);
struct nlm_wait block, **head;
int err;
u32 pstate;
@@ -69,7 +71,9 @@ nlmclnt_block(struct nlm_host *host, str
* a 1 minute timeout would do. See the comment before
* nlmclnt_lock for an explanation.
*/
- sleep_on_timeout(&block.b_wait, 30*HZ);
+ prepare_to_wait(&block.b_wait, &wait, TASK_UNINTERRUPTIBLE);
+ schedule_timeout(30*HZ);
+ finish_wait(&block.b_wait, &wait);
for (head = &nlm_blocked; *head; head = &(*head)->b_next) {
if (*head == &block) {
--
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-06-20 22:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-20 21:57 [patch 6/7] fs/clntlock: remove sleep_on*() usage domen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.