[uml-devel] [patch 1/1] um: copy_from_user size fix in signal.c

[uml-devel] [patch 1/1] um: copy_from_user size fix in signal.c

[domen]

[-- Attachment #1: size-arch_um_sys-i386_signal --]
[-- Type: text/plain, Size: 1355 bytes --]

From: Domen Puncer <domen@coderock.org>


Size of pointer doesn't seem right, but maybe my solution isn't
either (sig_size maybe?).


Signed-off-by: Domen Puncer <domen@coderock.org>

---
 signal.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: quilt/arch/um/sys-i386/signal.c
===================================================================
--- quilt.orig/arch/um/sys-i386/signal.c
+++ quilt/arch/um/sys-i386/signal.c
@@ -312,7 +312,7 @@ long sys_sigreturn(struct pt_regs regs)
 	unsigned long __user *extramask = frame->extramask;
 	int sig_size = (_NSIG_WORDS - 1) * sizeof(unsigned long);
 
-	if(copy_from_user(&set.sig[0], oldmask, sizeof(&set.sig[0])) ||
+	if(copy_from_user(&set.sig[0], oldmask, sizeof(set.sig[0])) ||
 	   copy_from_user(&set.sig[1], extramask, sig_size))
 		goto segfault;
 

--


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [patch 1/1] um: copy_from_user size fix in signal.c

[Blaisorblade]

On Monday 20 June 2005 23:50, domen@coderock.org wrote:
> From: Domen Puncer <domen@coderock.org>
>
>
> Size of pointer doesn't seem right, but maybe my solution isn't
> either (sig_size maybe?).
Your patch had already been submitted by Jeff a couple of hours before this 
mail. Thanks!
> Signed-off-by: Domen Puncer <domen@coderock.org>
>
> ---
>  signal.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: quilt/arch/um/sys-i386/signal.c
> ===================================================================
> --- quilt.orig/arch/um/sys-i386/signal.c
> +++ quilt/arch/um/sys-i386/signal.c
> @@ -312,7 +312,7 @@ long sys_sigreturn(struct pt_regs regs)
>  	unsigned long __user *extramask = frame->extramask;
>  	int sig_size = (_NSIG_WORDS - 1) * sizeof(unsigned long);
>
> -	if(copy_from_user(&set.sig[0], oldmask, sizeof(&set.sig[0])) ||
> +	if(copy_from_user(&set.sig[0], oldmask, sizeof(set.sig[0])) ||
>  	   copy_from_user(&set.sig[1], extramask, sig_size))
>  		goto segfault;
>
>
> --
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
> from IBM. Find simple to follow Roadmaps, straightforward articles,
> informative Webcasts and more! Get everything you need to get up to
> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
> _______________________________________________
> User-mode-linux-devel mailing list
> User-mode-linux-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it



-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [patch 1/1] um: copy_from_user size fix in signal.c

[Domen Puncer]

On 21/06/05 00:38 +0200, Blaisorblade wrote:
> On Monday 20 June 2005 23:50, domen@coderock.org wrote:
> > From: Domen Puncer <domen@coderock.org>
> >
> >
> > Size of pointer doesn't seem right, but maybe my solution isn't
> > either (sig_size maybe?).
> Your patch had already been submitted by Jeff a couple of hours before this 
> mail. Thanks!

And a put it in my dontsend file; another bug to be killed, i guess.
Sorry for the noise!

> > Signed-off-by: Domen Puncer <domen@coderock.org>
> >
> > ---
> >  signal.c |    2 +-
> >  1 files changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: quilt/arch/um/sys-i386/signal.c


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel