All of lore.kernel.org
 help / color / mirror / Atom feed
From: David McCullough <davidm@snapgear.com>
To: Linux Kernel List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Paul Mackerass <paulus@au.ibm.com>,
	Mikael Starvik <starvik@axis.com>
Subject: Re: [PATCH] Add removal schedule of register_serial/unregister_serial to appropriate file
Date: Mon, 27 Jun 2005 10:36:55 +1000	[thread overview]
Message-ID: <20050627003655.GD27196@beast> (raw)
In-Reply-To: <20050625104725.A16381@flint.arm.linux.org.uk>


Jivin Russell King lays it down ...
> On Thu, Jun 23, 2005 at 02:23:35PM +0100, Russell King wrote:
> > +What:	register_serial/unregister_serial
> > +When:	December 2005
> > +Why:	This interface does not allow serial ports to be registered against
> > +	a struct device, and as such does not allow correct power management
> > +	of such ports.  8250-based ports should use serial8250_register_port
> > +	and serial8250_unregister_port instead.
> > +Who:	Russell King <rmk@arm.linux.org.uk>
> 
> Ok, now that this is in, I guess I should arrange for register_serial &
> co to throw a compiler warning.  However, this is non-trivial because
> several other drivers declare this function:

...

> drivers/serial/68328serial.c:int register_serial(struct serial_struct *req)
> drivers/serial/68328serial.c:void unregister_serial(int line)

These can go.  AFAICT they were never used and I have no idea why they
are there.

Cheers,
Davidm

-- 
David McCullough, davidm@snapgear.com  Ph:+61 7 34352815 http://www.SnapGear.com
Custom Embedded Solutions + Security   Fx:+61 7 38913630 http://www.uCdot.org

  parent reply	other threads:[~2005-06-27  0:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-23 13:23 [PATCH] Add removal schedule of register_serial/unregister_serial to appropriate file Russell King
2005-06-23 13:54 ` Andi Kleen
2005-06-23 14:03 ` Adrian Bunk
2005-06-23 16:24   ` Andi Kleen
2005-06-23 18:32   ` Andrew Morton
2005-06-23 21:38     ` Dave Airlie
2005-06-23 19:13   ` Horst von Brand
2005-06-25  2:42 ` Pavel Machek
2005-06-25  9:47 ` Russell King
2005-06-25  9:57   ` Russell King
2005-06-27  0:36   ` David McCullough [this message]
2005-06-27  9:30     ` Russell King
2005-07-14 19:33 ` Russell King
2005-08-12 17:30   ` Max Asbock
2005-08-15  8:42     ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050627003655.GD27196@beast \
    --to=davidm@snapgear.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@au.ibm.com \
    --cc=starvik@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.