[KJ] [PATCH] fs/reiserfs/journal.c: replace direct assignment with

[KJ] [PATCH] fs/reiserfs/journal.c: replace direct assignment with

[Victor Fusco]

[-- Attachment #1: Type: text/plain, Size: 140 bytes --]

description:
Use set_current_state() instead of direct assignment of
current->state.

Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>

[-- Attachment #2: reiserfs_journal_set_current_state.patch --]
[-- Type: text/x-diff, Size: 520 bytes --]

diff -Nru linux-2.6.12/fs/reiserfs/journal.c linux-2.6.12-devel/fs/reiserfs/journal.c
--- linux-2.6.12/fs/reiserfs/journal.c	2005-06-17 19:48:29.000000000 +0000
+++ linux-2.6.12-devel/fs/reiserfs/journal.c	2005-06-27 14:13:59.000000000 +0000
@@ -2584,7 +2584,7 @@
     set_current_state(TASK_UNINTERRUPTIBLE);
     if (test_bit(J_WRITERS_QUEUED, &journal->j_state))
         schedule();
-    current->state = TASK_RUNNING;
+    set_current_state(TASK_RUNNING);
     remove_wait_queue(&journal->j_join_wait, &wait);
 }
 

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] fs/reiserfs/journal.c: replace direct assignment

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

On 27.06.2005 [20:59:13 +0000], Victor Fusco wrote:
> description:
> Use set_current_state() instead of direct assignment of
> current->state.

The memory barrier in set_current_state() (as opposed to
__set_current_state()) is not necessary for putting the state back to
RUNNING.

Thanks,
Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] fs/reiserfs/journal.c: replace direct assignment

[Victor Fusco]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

Em Ter 28 Jun 2005 03:40, você escreveu:
> On 27.06.2005 [20:59:13 +0000], Victor Fusco wrote:
> > description:
> > Use set_current_state() instead of direct assignment of
> > current->state.
> 
> The memory barrier in set_current_state() (as opposed to
> __set_current_state()) is not necessary for putting the state back to
> RUNNING.

Thanks. The patch with the correction is attached.

description:
Use __set_current_state() instead of direct assignment of
current->state.

Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>

[-- Attachment #2: reiserfs_journal_set_current_state.patch --]
[-- Type: text/x-diff, Size: 522 bytes --]

diff -Nru linux-2.6.12/fs/reiserfs/journal.c linux-2.6.12-devel/fs/reiserfs/journal.c
--- linux-2.6.12/fs/reiserfs/journal.c	2005-06-17 19:48:29.000000000 +0000
+++ linux-2.6.12-devel/fs/reiserfs/journal.c	2005-06-27 14:13:59.000000000 +0000
@@ -2584,7 +2584,7 @@
     set_current_state(TASK_UNINTERRUPTIBLE);
     if (test_bit(J_WRITERS_QUEUED, &journal->j_state))
         schedule();
-    current->state = TASK_RUNNING;
+    __set_current_state(TASK_RUNNING);
     remove_wait_queue(&journal->j_join_wait, &wait);
 }
 

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors