From: Alexey Dobriyan <adobriyan@gmail.com>
To: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Cc: Jean Delvare <khali@linux-fr.org>,
akpm@osdl.org, video4linux-list@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] V4L CX88 patch - against 2.6.12-mm2
Date: Wed, 29 Jun 2005 02:10:54 +0400 [thread overview]
Message-ID: <200506290210.54931.adobriyan@gmail.com> (raw)
In-Reply-To: <20050628232157.214c76fd.khali@linux-fr.org>
On Wednesday 29 June 2005 01:21, Jean Delvare wrote:
> Your patch adds trailing whitespace in various places:
[snip]
> Six people signing this patch and nobody noticed? Amazing.
>
> Please fix, thanks.
Also:
> --- linux-2.6.12-mm2/drivers/media/video/cx88/cx88-core.c
> +++ linux/drivers/media/video/cx88/cx88-core.c
> +/* Used only on cx88-core */
> static char *cx88_pci_irqs[32] = {
"static" already said that.
> +/* Used only on cx88-video */
> char *cx88_vid_irqs[32] = {
So move it there.
> +/* Used only on cx88-mpeg */
> char *cx88_mpeg_irqs[32] = {
Move this too.
> --- linux-2.6.12-mm2/drivers/media/video/cx88/cx88-input.c
> +++ linux/drivers/media/video/cx88/cx88-input.c
> +static IR_KEYTAB_TYPE ir_codes_msi_tvanywhere[IR_KEYTAB_SIZE] = {
> + [ 0x00 ] = KEY_0, /* '0' */
> + [ 0x01 ] = KEY_1, /* '1' */
> + [ 0x02 ] = KEY_2, /* '2' */
> + [ 0x03 ] = KEY_3, /* '3' */
> + [ 0x04 ] = KEY_4, /* '4' */
> + [ 0x05 ] = KEY_5, /* '5' */
> + [ 0x06 ] = KEY_6, /* '6' */
> + [ 0x07 ] = KEY_7, /* '7' */
> + [ 0x08 ] = KEY_8, /* '8' */
> + [ 0x09 ] = KEY_9, /* '9' */
> + [ 0x0c ] = KEY_MUTE, /* 'Mute' */
Duplicating comments.
> + [ 0x10 ] = KEY_F, /* 'Funtion' */
Function.
> + [ 0x12 ] = KEY_POWER, /* 'Power' */
> + [ 0x14 ] = KEY_SLOW, /* 'Slow' */
Duplicating comments.
next prev parent reply other threads:[~2005-06-28 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 19:05 [PATCH 1/1] V4L CX88 patch - against 2.6.12-mm2 Mauro Carvalho Chehab
2005-06-28 21:21 ` Jean Delvare
2005-06-28 21:30 ` Andrew Morton
2005-06-28 21:49 ` Mauro Carvalho Chehab
2005-06-28 22:10 ` Alexey Dobriyan [this message]
2005-07-17 3:57 ` David Lloyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506290210.54931.adobriyan@gmail.com \
--to=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.