All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ] Re: cleanup-drivers_usb_serial_cypress_m8.patch
@ 2005-06-29 17:03 Carlo Perassi
  0 siblings, 0 replies; only message in thread
From: Carlo Perassi @ 2005-06-29 17:03 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

> Well, this should be changed to:
> 
> 			tty->termios->c_cflag =
> 					B4800 | CS8 | CREAD | HUPCL | CLOCAL;

It is better.

> IMO, better
> 			priv->diff_status |=
> 				priv->current_status ^ priv->prev_status;

It is better too.

Do you need a new patch?

-- 
Carlo Perassi - http://www.linux.it/~carlo/

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-06-29 17:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-29 17:03 [KJ] Re: cleanup-drivers_usb_serial_cypress_m8.patch Carlo Perassi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.