All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: [Ocfs2-devel] [-mm patch] CONFIGFS_FS: "If unsure, say N."
Date: Wed Jun 29 19:47:35 2005	[thread overview]
Message-ID: <20050630004738.GA27478@stusta.de> (raw)
In-Reply-To: <20050629213038.GA23823@ca-server1.us.oracle.com>

On Wed, Jun 29, 2005 at 02:30:38PM -0700, Joel Becker wrote:
> On Fri, Jun 24, 2005 at 10:03:15AM +0200, Adrian Bunk wrote:
> > I haven't found any reason why CONFIGFS_FS is user-visible.
> > Other parts of the kernel using configfs should simply select it.
> 
> 	Doesn't work for external modules that might want to use it.
> Imagine that configfs gets merged before OCFS2, which depends on it.

I was surprised if configfs was merged with zero users in the kernel.

But I get your point, what about the patch below?

> Joel

cu
Adrian


<--  snip  -->


Make it clear that users usually shouldn't manually enable CONFIGFS_FS.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-mm2-full/fs/Kconfig.old	2005-06-30 01:51:51.000000000 +0200
+++ linux-2.6.12-mm2-full/fs/Kconfig	2005-06-30 01:54:01.000000000 +0200
@@ -934,13 +934,11 @@
 	tristate "Userspace-driven configuration filesystem (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
 	help
-	  configfs is a ram-based filesystem that provides the converse
-	  of sysfs's functionality. Where sysfs is a filesystem-based
-	  view of kernel objects, configfs is a filesystem-based manager
-	  of kernel objects, or config_items.
+	  This option is provided for the case where no in-kernel-tree
+	  modules require configfs, but a module built outside the kernel
+	  tree does. Such modules require Y or M here.
 
-	  Both sysfs and configfs can and should exist together on the
-	  same system. One is not a replacement for the other.
+	  If unsure, say N.
 
 config RELAYFS_FS
 	tristate "Relayfs file system support"

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: [-mm patch] CONFIGFS_FS: "If unsure, say N."
Date: Thu, 30 Jun 2005 02:47:38 +0200	[thread overview]
Message-ID: <20050630004738.GA27478@stusta.de> (raw)
In-Reply-To: <20050629213038.GA23823@ca-server1.us.oracle.com>

On Wed, Jun 29, 2005 at 02:30:38PM -0700, Joel Becker wrote:
> On Fri, Jun 24, 2005 at 10:03:15AM +0200, Adrian Bunk wrote:
> > I haven't found any reason why CONFIGFS_FS is user-visible.
> > Other parts of the kernel using configfs should simply select it.
> 
> 	Doesn't work for external modules that might want to use it.
> Imagine that configfs gets merged before OCFS2, which depends on it.

I was surprised if configfs was merged with zero users in the kernel.

But I get your point, what about the patch below?

> Joel

cu
Adrian


<--  snip  -->


Make it clear that users usually shouldn't manually enable CONFIGFS_FS.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-mm2-full/fs/Kconfig.old	2005-06-30 01:51:51.000000000 +0200
+++ linux-2.6.12-mm2-full/fs/Kconfig	2005-06-30 01:54:01.000000000 +0200
@@ -934,13 +934,11 @@
 	tristate "Userspace-driven configuration filesystem (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
 	help
-	  configfs is a ram-based filesystem that provides the converse
-	  of sysfs's functionality. Where sysfs is a filesystem-based
-	  view of kernel objects, configfs is a filesystem-based manager
-	  of kernel objects, or config_items.
+	  This option is provided for the case where no in-kernel-tree
+	  modules require configfs, but a module built outside the kernel
+	  tree does. Such modules require Y or M here.
 
-	  Both sysfs and configfs can and should exist together on the
-	  same system. One is not a replacement for the other.
+	  If unsure, say N.
 
 config RELAYFS_FS
 	tristate "Relayfs file system support"


  reply	other threads:[~2005-06-29 19:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-24  3:03 [Ocfs2-devel] [-mm patch] CONFIGFS_FS shouldn't be user-visible Adrian Bunk
2005-06-24  8:03 ` Adrian Bunk
2005-06-29 16:30 ` [Ocfs2-devel] " Joel Becker
2005-06-29 21:30   ` Joel Becker
2005-06-29 19:47   ` Adrian Bunk [this message]
2005-06-30  0:47     ` [-mm patch] CONFIGFS_FS: "If unsure, say N." Adrian Bunk
2005-06-29 19:57     ` [Ocfs2-devel] " Joel Becker
2005-06-30  0:57       ` Joel Becker
2005-06-29 20:10       ` Adrian Bunk
2005-06-30  1:10         ` Adrian Bunk
2005-06-29 20:30         ` Joel Becker
2005-06-30  1:30           ` Joel Becker
2005-07-02  5:58           ` Adrian Bunk
2005-07-02 10:58             ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050630004738.GA27478@stusta.de \
    --to=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.