[KJ] [PATCH 2.6.13-c1 4/17] fix sparse warnings (__nocast type)

[KJ] [PATCH 2.6.13-c1 4/17] fix sparse warnings (__nocast type)

[Victor Fusco]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

Description:
	Fix the sparse warning "implicit cast to nocast type"
 
File/Subsystem: drivers/pnp/pnpacpi

Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>
 

[-- Attachment #2: pnp_pnpacpi.patch --]
[-- Type: text/x-diff, Size: 1429 bytes --]

 drivers/pnp/pnpacpi/core.c    |    4 ++--
 drivers/pnp/pnpacpi/pnpacpi.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6-git/drivers/pnp/pnpacpi/core.c
===================================================================
--- linux-2.6-git.orig/drivers/pnp/pnpacpi/core.c	2005-07-03 15:40:59.000000000 +0000
+++ linux-2.6-git/drivers/pnp/pnpacpi/core.c	2005-07-03 16:52:12.000000000 +0000
@@ -41,9 +41,9 @@
 	return (!acpi_match_ids(dev, excluded_id_list));
 }
 
-void *pnpacpi_kmalloc(size_t size, int f)
+void *pnpacpi_kmalloc(size_t size, unsigned int __nocast flags)
 {
-	void *p = kmalloc(size, f);
+	void *p = kmalloc(size, flags);
 	if (p)
 		memset(p, 0, size);
 	return p;
Index: linux-2.6-git/drivers/pnp/pnpacpi/pnpacpi.h
===================================================================
--- linux-2.6-git.orig/drivers/pnp/pnpacpi/pnpacpi.h	2005-07-01 17:48:32.000000000 +0000
+++ linux-2.6-git/drivers/pnp/pnpacpi/pnpacpi.h	2005-07-03 16:52:03.000000000 +0000
@@ -5,7 +5,7 @@
 #include <linux/acpi.h>
 #include <linux/pnp.h>
 
-void *pnpacpi_kmalloc(size_t size, int f);
+void *pnpacpi_kmalloc(size_t size, unsigned int __nocast flags);
 acpi_status pnpacpi_parse_allocated_resource(acpi_handle, struct pnp_resource_table*);
 acpi_status pnpacpi_parse_resource_option_data(acpi_handle, struct pnp_dev*);
 int pnpacpi_encode_resources(struct pnp_resource_table *, struct acpi_buffer *);

[-- Attachment #3: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.13-c1 4/17] fix sparse warnings (__nocast type)

[Alexey Dobriyan]

On Sunday 03 July 2005 22:50, Victor Fusco wrote:
> --- linux-2.6-git.orig/drivers/pnp/pnpacpi/core.c
> +++ linux-2.6-git/drivers/pnp/pnpacpi/core.c

> -void *pnpacpi_kmalloc(size_t size, int f)
> +void *pnpacpi_kmalloc(size_t size, unsigned int __nocast flags)
>  {
> -	void *p = kmalloc(size, f);
> +	void *p = kmalloc(size, flags);
>  	if (p)
>  		memset(p, 0, size);
>  	return p;
   }

Sparse correctly reminds you that pnpacpi_kmalloc() is kcalloc() and should be
removed completely.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors