* audit function doc. question
@ 2005-07-06 18:59 randy_dunlap
2005-07-06 22:21 ` Chris Wright
0 siblings, 1 reply; 4+ messages in thread
From: randy_dunlap @ 2005-07-06 18:59 UTC (permalink / raw)
To: lkml; +Cc: linux-audit
kernel/audit.c (2.6.13-rc1-git5) audit_log_start() says:
/* Obtain an audit buffer. This routine does locking to obtain the
* audit buffer, but then no locking is required for calls to
* audit_log_*format. If the tsk is a task that is currently in a
* syscall, then the syscall is marked as auditable and an audit record
* will be written at syscall exit. If there is no associated task, tsk
* should be NULL. */
struct audit_buffer *audit_log_start(struct audit_context *ctx, int type)
{
What does <tsk> refer to in the function description?
There is no <tsk> in this function.
Thanks,
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: audit function doc. question
2005-07-06 18:59 audit function doc. question randy_dunlap
@ 2005-07-06 22:21 ` Chris Wright
2005-07-06 22:58 ` randy_dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Chris Wright @ 2005-07-06 22:21 UTC (permalink / raw)
To: randy_dunlap; +Cc: lkml, linux-audit
* randy_dunlap (rdunlap@xenotime.net) wrote:
> kernel/audit.c (2.6.13-rc1-git5) audit_log_start() says:
>
> /* Obtain an audit buffer. This routine does locking to obtain the
> * audit buffer, but then no locking is required for calls to
> * audit_log_*format. If the tsk is a task that is currently in a
> * syscall, then the syscall is marked as auditable and an audit record
> * will be written at syscall exit. If there is no associated task, tsk
> * should be NULL. */
> struct audit_buffer *audit_log_start(struct audit_context *ctx, int type)
> {
>
> What does <tsk> refer to in the function description?
> There is no <tsk> in this function.
It refers to tsk, tsk, stale comment. It's task->audit_context (which is
ctx there). Interested in preparing a patch, could even move to proper
kerneldoc format ;-)
thanks,
-chris
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: audit function doc. question
2005-07-06 22:21 ` Chris Wright
@ 2005-07-06 22:58 ` randy_dunlap
2005-07-07 1:32 ` Chris Wright
0 siblings, 1 reply; 4+ messages in thread
From: randy_dunlap @ 2005-07-06 22:58 UTC (permalink / raw)
To: Chris Wright; +Cc: linux-kernel, linux-audit
On Wed, 6 Jul 2005 15:21:15 -0700 Chris Wright wrote:
| * randy_dunlap (rdunlap@xenotime.net) wrote:
| > kernel/audit.c (2.6.13-rc1-git5) audit_log_start() says:
| >
| > /* Obtain an audit buffer. This routine does locking to obtain the
| > * audit buffer, but then no locking is required for calls to
| > * audit_log_*format. If the tsk is a task that is currently in a
| > * syscall, then the syscall is marked as auditable and an audit record
| > * will be written at syscall exit. If there is no associated task, tsk
| > * should be NULL. */
| > struct audit_buffer *audit_log_start(struct audit_context *ctx, int type)
| > {
| >
| > What does <tsk> refer to in the function description?
| > There is no <tsk> in this function.
|
| It refers to tsk, tsk, stale comment. It's task->audit_context (which is
| ctx there). Interested in preparing a patch, could even move to proper
| kerneldoc format ;-)
Yes, that's why I asked, I'm adding kerneldoc format comments
to audit*.c (2 files). You'll see it soon.
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-07-07 1:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-06 18:59 audit function doc. question randy_dunlap
2005-07-06 22:21 ` Chris Wright
2005-07-06 22:58 ` randy_dunlap
2005-07-07 1:32 ` Chris Wright
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.