All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Abhay Salunke <Abhay_Salunke@dell.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 2.6.12-rc3] modified firmware_class.c to add a new function request_firmware_nowait_nohotplug
Date: Fri, 8 Jul 2005 12:33:57 -0700	[thread overview]
Message-ID: <20050708193357.GC2228@kroah.com> (raw)
In-Reply-To: <20050709001657.GA29556@abhays.us.dell.com>

Wrong Subject:  :(

> +struct platform_device *rbu_device;
> +int context;

These should not be global variables.

You also have some functions that are global, please fix them.

thanks,

greg k-h

  reply	other threads:[~2005-07-08 19:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-09  0:16 [patch 2.6.12-rc3] modified firmware_class.c to add a new function request_firmware_nowait_nohotplug Abhay Salunke
2005-07-08 19:33 ` Greg KH [this message]
2005-07-08 21:12 ` randy_dunlap
2005-07-08 21:53 ` randy_dunlap
  -- strict thread matches above, loose matches on Subject: below --
2005-07-09  0:16 Abhay Salunke
2005-07-08 19:32 ` Greg KH
2005-07-08 21:14 Abhay_Salunke
2005-07-08 19:54 Abhay_Salunke
2005-07-08 22:24 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050708193357.GC2228@kroah.com \
    --to=greg@kroah.com \
    --cc=Abhay_Salunke@dell.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.