From: Greg KH <greg@kroah.com>
To: Abhay_Salunke@Dell.com
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 2.6.12-rc3] modified firmware_class.c to add a new function request_firmware_nowait_nohotplug
Date: Fri, 8 Jul 2005 15:24:38 -0700 [thread overview]
Message-ID: <20050708222438.GA22141@kroah.com> (raw)
In-Reply-To: <B37DF8F3777DDC4285FA831D366EB9E20730C7@ausx3mps302.aus.amer.dell.com>
On Fri, Jul 08, 2005 at 02:54:07PM -0500, Abhay_Salunke@Dell.com wrote:
> > Also, why not just add the hotplug flag to the firmware structure?
> That
> request_firmware kmalloc's the firmware structure and frees it when
> returned. The only way to indicate request_firmware to skip hotplug was
> by passing a hotplug flag on the stack.
Ok, how about changing the function to pass in a flag saying what it
wants (wait/nowait, hotplug/nohotplug) and fix up all callers of it?
> > way you don't have to add another function just to add another flag.
> > And you could probably get rid of the nowait version in the same way.
> Also thought of leaving request_firmware_nowait intact didn't want to
> break others using this function.
Did you find any other in-kernel use of request_firmware_nowait? I
don't see any :)
thanks,
greg k-h
next prev parent reply other threads:[~2005-07-08 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 19:54 [patch 2.6.12-rc3] modified firmware_class.c to add a new function request_firmware_nowait_nohotplug Abhay_Salunke
2005-07-08 22:24 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-08 21:14 Abhay_Salunke
2005-07-09 0:16 Abhay Salunke
2005-07-08 19:32 ` Greg KH
2005-07-09 0:16 Abhay Salunke
2005-07-08 19:33 ` Greg KH
2005-07-08 21:12 ` randy_dunlap
2005-07-08 21:53 ` randy_dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050708222438.GA22141@kroah.com \
--to=greg@kroah.com \
--cc=Abhay_Salunke@Dell.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.