From: Vojtech Pavlik <vojtech@suse.cz>
To: Pavel Machek <pavel@ucw.cz>
Cc: Marcel Selhorst <selhorst@crypto.rub.de>,
linux-kernel@vger.kernel.org, kjhall@us.ibm.com,
adobriyan@gmail.com
Subject: Re: [PATCH] tpm: Support for new chip type
Date: Sun, 10 Jul 2005 14:35:50 +0200 [thread overview]
Message-ID: <20050710123550.GA3378@ucw.cz> (raw)
In-Reply-To: <20050709191903.GB1553@elf.ucw.cz>
On Sat, Jul 09, 2005 at 09:19:04PM +0200, Pavel Machek wrote:
> Ugh, is it just me or are you abusing enums a bit?
> > +static int __init tpm_inf_probe(struct pci_dev *pci_dev,
> > + const struct pci_device_id *pci_id)
> > +{
> > +
> > + int rc = 0;
> > + u8 ioh;
> > + u8 iol;
>
> Put these two on one line? Are you sure probe can't be called during
> runtime for some pci hotplug case?
__devinit should be used here, if for nothing else, then for sanity's
sake.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2005-07-10 12:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-07 22:42 [PATCH] tpm: Support for new chip type Marcel Selhorst
2005-07-08 6:54 ` Philipp Matthias Hahn
2005-07-08 7:16 ` Alexey Dobriyan
2005-07-09 19:19 ` Pavel Machek
2005-07-10 12:35 ` Vojtech Pavlik [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-05 12:49 Marcel Selhorst
2005-07-05 15:03 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050710123550.GA3378@ucw.cz \
--to=vojtech@suse.cz \
--cc=adobriyan@gmail.com \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=selhorst@crypto.rub.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.