* [KJ] Re: [PATCH 6/14] ia64/sn: use msleep_interruptible() instead
2005-07-09 0:10 ` [PATCH 6/14] ia64/sn: use msleep_interruptible() instead of schedule_timeout() Nishanth Aravamudan
@ 2005-07-11 12:52 ` Dean Nelson
-1 siblings, 0 replies; 4+ messages in thread
From: Dean Nelson @ 2005-07-11 12:52 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Fri, Jul 08, 2005 at 05:10:22PM -0700, Nishanth Aravamudan wrote:
> From: Nishanth Aravamudan <nacc@us.ibm.com>
>
> Description: Replace schedule_timeout() with msleep_interruptible() to
> guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Your changes to arch/ia64/sn/kernel/xpc_main.c looked good to me. Thanks.
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 6/14] ia64/sn: use msleep_interruptible() instead of schedule_timeout()
@ 2005-07-11 12:52 ` Dean Nelson
0 siblings, 0 replies; 4+ messages in thread
From: Dean Nelson @ 2005-07-11 12:52 UTC (permalink / raw)
To: kernel-janitors
On Fri, Jul 08, 2005 at 05:10:22PM -0700, Nishanth Aravamudan wrote:
> From: Nishanth Aravamudan <nacc@us.ibm.com>
>
> Description: Replace schedule_timeout() with msleep_interruptible() to
> guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Your changes to arch/ia64/sn/kernel/xpc_main.c looked good to me. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [KJ] [PATCH 6/14] ia64/sn: use msleep_interruptible() instead of
@ 2005-07-09 0:10 ` Nishanth Aravamudan
0 siblings, 0 replies; 4+ messages in thread
From: Nishanth Aravamudan @ 2005-07-09 0:10 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1667 bytes --]
From: Nishanth Aravamudan <nacc@us.ibm.com>
Description: Replace schedule_timeout() with msleep_interruptible() to
guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
---
xpc_main.c | 15 +++++----------
1 files changed, 5 insertions(+), 10 deletions(-)
diff -urp 2.6.13-rc2-kj/arch/ia64/sn/kernel/xpc_main.c 2.6.13-rc2-kj-dev/arch/ia64/sn/kernel/xpc_main.c
--- 2.6.13-rc2-kj/arch/ia64/sn/kernel/xpc_main.c 2005-07-06 07:57:02.000000000 -0700
+++ 2.6.13-rc2-kj-dev/arch/ia64/sn/kernel/xpc_main.c 2005-07-08 15:29:46.000000000 -0700
@@ -53,6 +53,7 @@
#include <linux/cache.h>
#include <linux/interrupt.h>
#include <linux/slab.h>
+#include <linux/delay.h>
#include <asm/sn/intr.h>
#include <asm/sn/sn_sal.h>
#include <asm/uaccess.h>
@@ -308,8 +309,7 @@ xpc_make_first_contact(struct xpc_partit
"partition %d\n", XPC_PARTID(part));
/* wait a 1/4 of a second or so */
- set_current_state(TASK_INTERRUPTIBLE);
- (void) schedule_timeout(0.25 * HZ);
+ msleep_interruptible(250);
if (part->act_state == XPC_P_DEACTIVATING) {
return part->reason;
@@ -841,9 +841,7 @@ xpc_do_exit(void)
down(&xpc_discovery_exited);
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(0.3 * HZ);
- set_current_state(TASK_RUNNING);
+ msleep_interruptible(300);
/* wait for all partitions to become inactive */
@@ -860,11 +858,8 @@ xpc_do_exit(void)
}
}
- if (active_part_count) {
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(0.3 * HZ);
- set_current_state(TASK_RUNNING);
- }
+ if (active_part_count)
+ msleep_interruptible(300);
} while (active_part_count > 0);
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 6/14] ia64/sn: use msleep_interruptible() instead of schedule_timeout()
@ 2005-07-09 0:10 ` Nishanth Aravamudan
0 siblings, 0 replies; 4+ messages in thread
From: Nishanth Aravamudan @ 2005-07-09 0:10 UTC (permalink / raw)
To: kernel-janitors
From: Nishanth Aravamudan <nacc@us.ibm.com>
Description: Replace schedule_timeout() with msleep_interruptible() to
guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
---
xpc_main.c | 15 +++++----------
1 files changed, 5 insertions(+), 10 deletions(-)
diff -urp 2.6.13-rc2-kj/arch/ia64/sn/kernel/xpc_main.c 2.6.13-rc2-kj-dev/arch/ia64/sn/kernel/xpc_main.c
--- 2.6.13-rc2-kj/arch/ia64/sn/kernel/xpc_main.c 2005-07-06 07:57:02.000000000 -0700
+++ 2.6.13-rc2-kj-dev/arch/ia64/sn/kernel/xpc_main.c 2005-07-08 15:29:46.000000000 -0700
@@ -53,6 +53,7 @@
#include <linux/cache.h>
#include <linux/interrupt.h>
#include <linux/slab.h>
+#include <linux/delay.h>
#include <asm/sn/intr.h>
#include <asm/sn/sn_sal.h>
#include <asm/uaccess.h>
@@ -308,8 +309,7 @@ xpc_make_first_contact(struct xpc_partit
"partition %d\n", XPC_PARTID(part));
/* wait a 1/4 of a second or so */
- set_current_state(TASK_INTERRUPTIBLE);
- (void) schedule_timeout(0.25 * HZ);
+ msleep_interruptible(250);
if (part->act_state = XPC_P_DEACTIVATING) {
return part->reason;
@@ -841,9 +841,7 @@ xpc_do_exit(void)
down(&xpc_discovery_exited);
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(0.3 * HZ);
- set_current_state(TASK_RUNNING);
+ msleep_interruptible(300);
/* wait for all partitions to become inactive */
@@ -860,11 +858,8 @@ xpc_do_exit(void)
}
}
- if (active_part_count) {
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(0.3 * HZ);
- set_current_state(TASK_RUNNING);
- }
+ if (active_part_count)
+ msleep_interruptible(300);
} while (active_part_count > 0);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-07-11 12:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-11 12:52 [KJ] Re: [PATCH 6/14] ia64/sn: use msleep_interruptible() instead Dean Nelson
2005-07-11 12:52 ` [PATCH 6/14] ia64/sn: use msleep_interruptible() instead of schedule_timeout() Dean Nelson
-- strict thread matches above, loose matches on Subject: below --
2005-07-09 0:10 [KJ] [PATCH 6/14] ia64/sn: use msleep_interruptible() instead of Nishanth Aravamudan
2005-07-09 0:10 ` [PATCH 6/14] ia64/sn: use msleep_interruptible() instead of schedule_timeout() Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.