* [KJ] [patch 2.6.13-rc1 17/23] Audit return code of create_proc_*
@ 2005-07-07 15:44 Christophe Lucas
2005-07-12 12:03 ` Christophe Lucas
2005-07-12 12:23 ` Domen Puncer
0 siblings, 2 replies; 3+ messages in thread
From: Christophe Lucas @ 2005-07-07 15:44 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: proc_create_arch_ppc_platforms_residual.c.diff --]
[-- Type: text/plain, Size: 701 bytes --]
diff -urpNX dontdiff 2.6.13-rc1.orig/arch/ppc/platforms/residual.c 2.6.13-rc1/arch/ppc/platforms/residual.c
--- 2.6.13-rc1.orig/arch/ppc/platforms/residual.c 2005-06-29 07:57:29.000000000 +0200
+++ 2.6.13-rc1/arch/ppc/platforms/residual.c 2005-07-05 10:18:36.331535824 +0200
@@ -1024,9 +1024,13 @@ static int proc_prep_residual_read(char
int __init
proc_prep_residual_init(void)
{
+ struct proc_dir_entry* ent;
if (have_residual_data)
- create_proc_read_entry("residual", S_IRUGO, NULL,
+ ent = create_proc_read_entry("residual", S_IRUGO, NULL,
proc_prep_residual_read, NULL);
+ if (!ent)
+ printk(KERN_WARNING
+ "residual: Unable to create /proc entry.\n");
return 0;
}
--
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* [KJ] [patch 2.6.13-rc1 17/23] Audit return code of create_proc_*
2005-07-07 15:44 [KJ] [patch 2.6.13-rc1 17/23] Audit return code of create_proc_* Christophe Lucas
@ 2005-07-12 12:03 ` Christophe Lucas
2005-07-12 12:23 ` Domen Puncer
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Lucas @ 2005-07-12 12:03 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
Description:
Audit return of create_proc_* functions.
Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
Index: 2.6.13-rc1/arch/ppc/platforms/residual.c
===================================================================
--- 2.6.13-rc1.orig/arch/ppc/platforms/residual.c
+++ 2.6.13-rc1/arch/ppc/platforms/residual.c
@@ -1024,9 +1024,13 @@ static int proc_prep_residual_read(char
int __init
proc_prep_residual_init(void)
{
+ struct proc_dir_entry *ent;
if (have_residual_data)
- create_proc_read_entry("residual", S_IRUGO, NULL,
+ ent = create_proc_read_entry("residual", S_IRUGO, NULL,
proc_prep_residual_read, NULL);
+ if (!ent)
+ printk(KERN_WARNING
+ "residual: Unable to create /proc entry.\n");
return 0;
}
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ] [patch 2.6.13-rc1 17/23] Audit return code of create_proc_*
2005-07-07 15:44 [KJ] [patch 2.6.13-rc1 17/23] Audit return code of create_proc_* Christophe Lucas
2005-07-12 12:03 ` Christophe Lucas
@ 2005-07-12 12:23 ` Domen Puncer
1 sibling, 0 replies; 3+ messages in thread
From: Domen Puncer @ 2005-07-12 12:23 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On 12/07/05 14:03 +0200, Christophe Lucas wrote:
> Description:
> Audit return of create_proc_* functions.
>
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
>
> Index: 2.6.13-rc1/arch/ppc/platforms/residual.c
> ===================================================================
> --- 2.6.13-rc1.orig/arch/ppc/platforms/residual.c
> +++ 2.6.13-rc1/arch/ppc/platforms/residual.c
> @@ -1024,9 +1024,13 @@ static int proc_prep_residual_read(char
> int __init
> proc_prep_residual_init(void)
> {
> + struct proc_dir_entry *ent;
> if (have_residual_data)
^ missing '{'?
> - create_proc_read_entry("residual", S_IRUGO, NULL,
> + ent = create_proc_read_entry("residual", S_IRUGO, NULL,
> proc_prep_residual_read, NULL);
> + if (!ent)
> + printk(KERN_WARNING
^ whitespace :-)
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-07-12 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-07 15:44 [KJ] [patch 2.6.13-rc1 17/23] Audit return code of create_proc_* Christophe Lucas
2005-07-12 12:03 ` Christophe Lucas
2005-07-12 12:23 ` Domen Puncer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.