All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [patch 2.6.13-rc1 19/23][RESEND] Audit return code of
Date: Wed, 13 Jul 2005 17:31:42 +0000	[thread overview]
Message-ID: <20050713173142.GA21831@homer.coderock.org> (raw)
In-Reply-To: <20050712120511.GF4712@rhum.iomeda.fr>

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On 12/07/05 14:05 +0200, Christophe Lucas wrote:
> Description:
> Audit return of create_proc_* functions.
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> 
> 
> Index: 2.6.13-rc1/arch/m68k/mac/iop.c
> ===================================================================
> --- 2.6.13-rc1.orig/arch/m68k/mac/iop.c
> +++ 2.6.13-rc1/arch/m68k/mac/iop.c
> @@ -275,6 +275,7 @@ void __init iop_preinit(void)
>  
>  void __init iop_init(void)
>  {
> +	struct proc_dir_entry *proc_entry;
>  	int i;
>  
>  	if (iop_scc_present) {
> @@ -303,7 +304,10 @@ void __init iop_init(void)
>  
>  #if 0	/* Crashing in 2.4 now, not yet sure why.   --jmt */
>  #ifdef CONFIG_PROC_FS
> -	create_proc_info_entry("mac_iop", 0, &proc_root, iop_get_proc_info);
> +	proc_entry = create_proc_info_entry("mac_iop", 0, 
> +		&proc_root, iop_get_proc_info);
> +	if (!proc_entry)
> +		printk(KERN_WARNING "iop: Unable to create /proc entry.\n");
>  #endif
>  #endif

This adds a warning about unused variable; not good.

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      reply	other threads:[~2005-07-13 17:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-12 12:05 [KJ] [patch 2.6.13-rc1 19/23][RESEND] Audit return code of Christophe Lucas
2005-07-13 17:31 ` Domen Puncer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050713173142.GA21831@homer.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.