[KJ] [patch 2.6.13-rc1 19/23][RESEND] Audit return code of

[KJ] [patch 2.6.13-rc1 19/23][RESEND] Audit return code of

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Description:
Audit return of create_proc_* functions.

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>


Index: 2.6.13-rc1/arch/m68k/mac/iop.c
===================================================================
--- 2.6.13-rc1.orig/arch/m68k/mac/iop.c
+++ 2.6.13-rc1/arch/m68k/mac/iop.c
@@ -275,6 +275,7 @@ void __init iop_preinit(void)
 
 void __init iop_init(void)
 {
+	struct proc_dir_entry *proc_entry;
 	int i;
 
 	if (iop_scc_present) {
@@ -303,7 +304,10 @@ void __init iop_init(void)
 
 #if 0	/* Crashing in 2.4 now, not yet sure why.   --jmt */
 #ifdef CONFIG_PROC_FS
-	create_proc_info_entry("mac_iop", 0, &proc_root, iop_get_proc_info);
+	proc_entry = create_proc_info_entry("mac_iop", 0, 
+		&proc_root, iop_get_proc_info);
+	if (!proc_entry)
+		printk(KERN_WARNING "iop: Unable to create /proc entry.\n");
 #endif
 #endif
 }

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [patch 2.6.13-rc1 19/23][RESEND] Audit return code of

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On 12/07/05 14:05 +0200, Christophe Lucas wrote:
> Description:
> Audit return of create_proc_* functions.
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> 
> 
> Index: 2.6.13-rc1/arch/m68k/mac/iop.c
> ===================================================================
> --- 2.6.13-rc1.orig/arch/m68k/mac/iop.c
> +++ 2.6.13-rc1/arch/m68k/mac/iop.c
> @@ -275,6 +275,7 @@ void __init iop_preinit(void)
>  
>  void __init iop_init(void)
>  {
> +	struct proc_dir_entry *proc_entry;
>  	int i;
>  
>  	if (iop_scc_present) {
> @@ -303,7 +304,10 @@ void __init iop_init(void)
>  
>  #if 0	/* Crashing in 2.4 now, not yet sure why.   --jmt */
>  #ifdef CONFIG_PROC_FS
> -	create_proc_info_entry("mac_iop", 0, &proc_root, iop_get_proc_info);
> +	proc_entry = create_proc_info_entry("mac_iop", 0, 
> +		&proc_root, iop_get_proc_info);
> +	if (!proc_entry)
> +		printk(KERN_WARNING "iop: Unable to create /proc entry.\n");
>  #endif
>  #endif

This adds a warning about unused variable; not good.

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors