From: Adrian Bunk <bunk@stusta.de>
To: Urban Widmark <urban@teststation.com>
Cc: samba@samba.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] fs/smbfs/request.c: turn NULL dereference into BUG()
Date: Fri, 15 Jul 2005 23:34:54 +0200 [thread overview]
Message-ID: <20050715213454.GF18059@stusta.de> (raw)
In a case documented as
We should never be called with any of these states
BUG() in a case that would later result in a NULL pointer dereference.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 26 Mar 2005
--- linux-2.6.12-rc1-mm3-full/fs/smbfs/request.c.old 2005-03-26 13:19:19.000000000 +0100
+++ linux-2.6.12-rc1-mm3-full/fs/smbfs/request.c 2005-03-26 13:41:30.000000000 +0100
@@ -786,8 +642,7 @@ int smb_request_recv(struct smb_sb_info
/* We should never be called with any of these states */
case SMB_RECV_END:
case SMB_RECV_REQUEST:
- server->rstate = SMB_RECV_END;
- break;
+ BUG();
}
if (result < 0) {
next reply other threads:[~2005-07-15 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-15 21:34 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-10-31 11:13 [2.6 patch] fs/smbfs/request.c: turn NULL dereference into BUG() Adrian Bunk
2005-03-25 0:15 [2.6 patch] fs/smbfs/request.c: fix NULL dereference Adrian Bunk
2005-03-26 9:02 ` Jean Delvare
2005-03-26 12:53 ` [2.6 patch] fs/smbfs/request.c: turn NULL dereference into BUG() Adrian Bunk
2005-03-26 13:11 ` Adrian Bunk
2005-03-26 18:16 ` Jean Delvare
2005-04-09 8:47 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050715213454.GF18059@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=samba@samba.org \
--cc=urban@teststation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.