From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] new ELF64 patch
Date: Tue, 19 Jul 2005 21:33:45 +0200 [thread overview]
Message-ID: <200507192133.45201.okuji@enbug.org> (raw)
In-Reply-To: <11095bcfc8289c38cb4bd5cc613d1347@penguinppc.org>
On Monday 18 July 2005 17:18, Hollis Blanchard wrote:
> I don't like this. I would prefer having grub_rescue_cmd_multiboot()
> call two functions: grub_load_elf32() and grub_load_elf64():
>
> grub_load_elf32(Elf32_Ehdr *header)
> {
> if (header->e_ident[EI_CLASS] != ELFCLASS32)
> return error;
>
> /* load segments */
> ...
> }
I agree. This is more readable.
Okuji
next prev parent reply other threads:[~2005-07-19 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-16 22:54 [PATCH] new ELF64 patch Ruslan Nikolaev
2005-07-18 15:18 ` Hollis Blanchard
2005-07-19 19:33 ` Yoshinori K. Okuji [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-17 22:32 Ruslan Nikolaev
2005-07-18 3:34 ` Joel Buckley
2005-07-18 9:19 ` Yoshinori K. Okuji
2005-07-18 9:15 ` Yoshinori K. Okuji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507192133.45201.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.