From: Greg KH <greg@kroah.com>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
"David S. Miller" <davem@davemloft.net>,
rmk+lkml@arm.linux.org.uk, matthew@wil.cx,
grundler@parisc-linux.org, linux-pci@atrey.karlin.mff.cuni.cz,
linux-pm@lists.osdl.org, linux-kernel@vger.kernel.org,
ambx1@neo.rr.com
Subject: Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0
Date: Tue, 26 Jul 2005 16:49:34 -0700 [thread overview]
Message-ID: <20050726234934.GA6584@kroah.com> (raw)
In-Reply-To: <20050708183452.GB13445@tuxdriver.com>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote:
> @@ -301,6 +335,16 @@ pci_set_power_state(struct pci_dev *dev,
> udelay(200);
> dev->current_state = state;
>
> + /* According to section 5.4.1 of the "PCI BUS POWER MANAGEMENT
> + * INTERFACE SPECIFICATION, REV. 1.2", a device transitioning
> + * from D3hot to D0 _may_ perform an internal reset, thereby
> + * going to "D0 Uninitialized" rather than "D0 Initialized".
> + * In that case, we need to restore at least the BARs so that
> + * the device will be accessible to its driver.
> + */
> + if (need_restore)
> + pci_restore_bars(dev);
> +
This code doesn't even build, as need_restore isn't a global variable.
Care to redo this patch (and merge it with your other one) and resend
it?
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
"David S. Miller" <davem@davemloft.net>,
rmk+lkml@arm.linux.org.uk, matthew@wil.cx,
grundler@parisc-linux.org, linux-pci@atrey.karlin.mff.cuni.cz,
linux-pm@lists.osdl.org, linux-kernel@vger.kernel.org,
ambx1@neo.rr.com
Subject: Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0
Date: Tue, 26 Jul 2005 16:49:34 -0700 [thread overview]
Message-ID: <20050726234934.GA6584@kroah.com> (raw)
In-Reply-To: <20050708183452.GB13445@tuxdriver.com>
On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote:
> @@ -301,6 +335,16 @@ pci_set_power_state(struct pci_dev *dev,
> udelay(200);
> dev->current_state = state;
>
> + /* According to section 5.4.1 of the "PCI BUS POWER MANAGEMENT
> + * INTERFACE SPECIFICATION, REV. 1.2", a device transitioning
> + * from D3hot to D0 _may_ perform an internal reset, thereby
> + * going to "D0 Uninitialized" rather than "D0 Initialized".
> + * In that case, we need to restore at least the BARs so that
> + * the device will be accessible to its driver.
> + */
> + if (need_restore)
> + pci_restore_bars(dev);
> +
This code doesn't even build, as need_restore isn't a global variable.
Care to redo this patch (and merge it with your other one) and resend
it?
thanks,
greg k-h
next prev parent reply other threads:[~2005-07-26 23:49 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 19:14 [RFC] firmware leaves device in D3hot at boot John W. Linville
2005-06-23 19:14 ` John W. Linville
2005-06-24 2:28 ` John W. Linville
2005-06-24 2:28 ` John W. Linville
2005-06-30 17:10 ` Greg KH
2005-06-30 17:10 ` Greg KH
2005-07-01 1:41 ` John W. Linville
2005-07-01 1:41 ` John W. Linville
2005-07-01 2:26 ` [patch 2.6.12] pci: restore BAR values in pci_enable_device John W. Linville
2005-07-01 2:26 ` John W. Linville
2005-07-01 2:26 ` [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars John W. Linville
2005-07-01 2:26 ` John W. Linville
2005-07-02 7:29 ` Grant Grundler
2005-07-02 7:29 ` Grant Grundler
2005-07-02 8:09 ` Russell King
2005-07-02 8:09 ` Russell King
2005-07-05 20:05 ` Matthew Wilcox
2005-07-05 20:05 ` Matthew Wilcox
2005-07-05 21:46 ` Russell King
2005-07-05 21:46 ` Russell King
2005-07-05 23:34 ` Ivan Kokshaysky
2005-07-05 23:34 ` Ivan Kokshaysky
2005-07-06 7:46 ` Russell King
2005-07-06 7:46 ` Russell King
2005-07-08 0:57 ` John W. Linville
2005-07-08 0:57 ` John W. Linville
2005-07-08 0:59 ` [patch 2.6.13-rc2] pci: restore BAR values in pci_set_power_state for D3hot->D0 John W. Linville
2005-07-08 0:59 ` John W. Linville
2005-07-08 3:43 ` [linux-pm] " david-b
2005-07-08 3:43 ` david-b
2005-07-08 12:37 ` John W. Linville
2005-07-08 12:37 ` [linux-pm] " John W. Linville
2005-07-08 3:11 ` [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars David S. Miller
2005-07-08 3:11 ` David S. Miller
2005-07-08 5:51 ` Ivan Kokshaysky
2005-07-08 5:51 ` Ivan Kokshaysky
2005-07-08 6:35 ` David S. Miller
2005-07-08 6:35 ` David S. Miller
2005-07-08 7:03 ` Ivan Kokshaysky
2005-07-08 7:03 ` Ivan Kokshaysky
2005-07-08 7:33 ` David S. Miller
2005-07-08 7:33 ` David S. Miller
2005-07-08 8:20 ` Ivan Kokshaysky
2005-07-08 8:20 ` Ivan Kokshaysky
2005-07-08 18:34 ` [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0 John W. Linville
2005-07-08 18:34 ` John W. Linville
2005-07-08 19:08 ` David S. Miller
2005-07-08 19:08 ` David S. Miller
2005-07-10 17:53 ` Ivan Kokshaysky
2005-07-10 17:53 ` Ivan Kokshaysky
2005-07-11 12:48 ` Lennert Buytenhek
2005-07-11 12:48 ` Lennert Buytenhek
2005-07-11 13:15 ` John W. Linville
2005-07-11 13:15 ` John W. Linville
2005-07-11 13:19 ` [patch 2.6.13-rc2] PCI: Add symbol exports for pci_restore_bars John W. Linville
2005-07-11 13:19 ` John W. Linville
2005-07-11 17:18 ` Greg KH
2005-07-11 17:36 ` John W. Linville
2005-07-11 17:36 ` John W. Linville
2005-07-11 17:38 ` [patch 2.6.13-rc2] PCI: Add GPL symbol export " John W. Linville
2005-07-11 17:38 ` John W. Linville
2005-07-12 2:28 ` [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0 Adam Belay
2005-07-12 2:28 ` Adam Belay
2005-07-13 17:34 ` John W. Linville
2005-07-13 17:34 ` John W. Linville
2005-07-26 23:49 ` Greg KH [this message]
2005-07-26 23:49 ` Greg KH
2005-07-27 1:36 ` John W. Linville
2005-07-27 1:36 ` John W. Linville
2005-07-27 14:12 ` John W. Linville
2005-07-27 14:12 ` John W. Linville
2005-07-27 14:19 ` [patch 2.6.13-rc3] pci: restore BAR values after D3hot->D0 for devices that need it John W. Linville
2005-07-27 14:19 ` John W. Linville
2005-07-31 19:36 ` Ralf Baechle
2005-07-31 19:36 ` Ralf Baechle
2005-08-02 17:31 ` Greg KH
2005-08-02 17:31 ` Greg KH
2005-08-02 16:41 ` Jesse Brandeburg
2005-09-14 13:52 ` [patch 2.6.14-rc1] pci: only call pci_restore_bars at boot John W. Linville
2005-09-14 13:52 ` John W. Linville
2005-09-14 15:08 ` Jeff Garzik
2005-09-14 15:08 ` Jeff Garzik
2005-09-14 16:26 ` David S. Miller
2005-09-14 16:47 ` John W. Linville
2005-09-14 16:47 ` John W. Linville
2005-09-14 18:22 ` Ivan Kokshaysky
2005-09-14 18:22 ` Ivan Kokshaysky
2005-07-05 17:46 ` [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars John W. Linville
2005-07-05 17:46 ` John W. Linville
2005-07-18 12:17 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050726234934.GA6584@kroah.com \
--to=greg@kroah.com \
--cc=ambx1@neo.rr.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-pm@lists.osdl.org \
--cc=matthew@wil.cx \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.