exporting TCQ functionality to the kernel in SYMBIOS/NCR 53C8XX driver

exporting TCQ functionality to the kernel in SYMBIOS/NCR 53C8XX driver

[Philipp Reisner]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi Matthew,

Does this patch makes sense to you ?
Could you consider this for inclusion into mainline ?

best regards,
 Philipp
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria    http://www.linbit.com :

[-- Attachment #2: sym53c8xxx-tcq-support.diff --]
[-- Type: text/x-diff, Size: 823 bytes --]

diff -ur linux-2.6.12+kdb/drivers/scsi/sym53c8xx_2/sym_glue.c linux-2.6.12+kdb+sym-patch/drivers/scsi/sym53c8xx_2/sym_glue.c
--- linux-2.6.12+kdb/drivers/scsi/sym53c8xx_2/sym_glue.c	2005-07-27 10:54:47.000000000 +0200
+++ linux-2.6.12+kdb+sym-patch/drivers/scsi/sym53c8xx_2/sym_glue.c	2005-07-27 11:07:47.000000000 +0200
@@ -494,7 +494,14 @@
 	 *  Select tagged/untagged.
 	 */
 	lp = sym_lp(tp, sdev->lun);
-	order = (lp && lp->s.reqtags) ? M_SIMPLE_TAG : 0;
+        if (lp && lp->s.reqtags) {
+		if (cmd->request->flags & REQ_HARDBARRIER)
+			order = M_ORDERED_TAG;
+		else
+			order = M_SIMPLE_TAG;
+	} else {
+		order = 0 ;
+	}
 
 	/*
 	 *  Queue the SCSI IO.
@@ -1926,6 +1933,7 @@
 	.proc_info		= sym53c8xx_proc_info,
 	.proc_name		= NAME53C8XX,
 #endif
+	.ordered_tag            = 1,
 };
 
 static int attach_count;

Re: exporting TCQ functionality to the kernel in SYMBIOS/NCR 53C8XX driver

[Matthew Wilcox]

On Wed, Jul 27, 2005 at 11:33:33AM +0200, Philipp Reisner wrote:
> Hi Matthew,
> 
> Does this patch makes sense to you ?
> Could you consider this for inclusion into mainline ?

Does it actually do anything?  The sym2 driver doesn't use the generic
midlayer queue tagging code at all yet, so could this flag ever get set?

I must admit, I was hoping you'd done the work to make that happen, but
I guess I'll have to do it myself (which will make this patch irrelevant).

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain