From: Domen Puncer <domen@coderock.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH][1/3] ppc32: add 440ep support
Date: Thu, 28 Jul 2005 15:02:19 +0200 [thread overview]
Message-ID: <20050728130219.GB2249@homer.coderock.org> (raw)
In-Reply-To: <17128.4407.838024.111955@cargo.ozlabs.ibm.com>
On 27/07/05 18:56 -0400, Paul Mackerras wrote:
> Andrew Morton writes:
>
> > Matt Porter <mporter@kernel.crashing.org> wrote:
> > >
> > > +static u64 dma_mask = 0xffffffffULL;
How about just DMA_32BIT_MASK from dma-mapping.h, that one has to be
correct. ;-)
> >
> > I'm sure you're totally uninterested in this, but the above will probably
> > generate warnings on (say) ppc64, where u64 is implemented as unsigned
> > long.
> >
> > I usually chuck a simple `-1' in there and the compiler always gets it
> > right, regardless of signedness and size and architecture.
>
> Umm, I think we actually want 2^32-1 not -1, don't we? In which case
> I think Matt's code is what we have to have.
>
> I tried a little test compile with gcc 4.0 with -m64 -Wall and it
> didn't generate a warning with the 0xffffffffULL constant.
WARNING: multiple messages have this Message-ID (diff)
From: Domen Puncer <domen@coderock.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Andrew Morton <akpm@osdl.org>,
Matt Porter <mporter@kernel.crashing.org>,
wfarnsworth@mvista.com, linuxppc-embedded@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][1/3] ppc32: add 440ep support
Date: Thu, 28 Jul 2005 15:02:19 +0200 [thread overview]
Message-ID: <20050728130219.GB2249@homer.coderock.org> (raw)
In-Reply-To: <17128.4407.838024.111955@cargo.ozlabs.ibm.com>
On 27/07/05 18:56 -0400, Paul Mackerras wrote:
> Andrew Morton writes:
>
> > Matt Porter <mporter@kernel.crashing.org> wrote:
> > >
> > > +static u64 dma_mask = 0xffffffffULL;
How about just DMA_32BIT_MASK from dma-mapping.h, that one has to be
correct. ;-)
> >
> > I'm sure you're totally uninterested in this, but the above will probably
> > generate warnings on (say) ppc64, where u64 is implemented as unsigned
> > long.
> >
> > I usually chuck a simple `-1' in there and the compiler always gets it
> > right, regardless of signedness and size and architecture.
>
> Umm, I think we actually want 2^32-1 not -1, don't we? In which case
> I think Matt's code is what we have to have.
>
> I tried a little test compile with gcc 4.0 with -m64 -Wall and it
> didn't generate a warning with the 0xffffffffULL constant.
next prev parent reply other threads:[~2005-07-28 13:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-27 17:34 [PATCH][1/3] ppc32: add 440ep support Matt Porter
2005-07-27 17:34 ` Matt Porter
2005-07-27 17:34 ` [PATCH][2/3] ppc32: add bamboo platform Matt Porter
2005-07-27 17:34 ` Matt Porter
2005-07-27 17:34 ` [PATCH][3/3] ppc32: add bamboo defconfig Matt Porter
2005-07-27 17:34 ` Matt Porter
2005-07-27 20:18 ` [PATCH][1/3] ppc32: add 440ep support Andrew Morton
2005-07-27 20:18 ` Andrew Morton
2005-07-27 22:56 ` Paul Mackerras
2005-07-27 22:56 ` Paul Mackerras
2005-07-27 23:03 ` Andrew Morton
2005-07-27 23:03 ` Andrew Morton
2005-07-28 13:02 ` Domen Puncer [this message]
2005-07-28 13:02 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050728130219.GB2249@homer.coderock.org \
--to=domen@coderock.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.