From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pm@lists.osdl.org,
Michal Schmidt <xschmi00@stud.feec.vutbr.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] swsusp: simpler calculation of number of pages in PBE list
Date: Sat, 30 Jul 2005 15:13:56 +0200 [thread overview]
Message-ID: <20050730131356.GE1830@elf.ucw.cz> (raw)
In-Reply-To: <200507301516.32003.rjw@sisk.pl>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
Hi!
> > px >= n + x
> >
> > or
> >
> > (p-1)x >= n
> >
> > or
> >
> > x >= n / (p-1).
> >
> > The obvious solution is
> >
> > x = ceiling(n / (p-1)),
> >
> > so calc_nr should return n + ceiling(n / (p-1)), which is exactly what
> > Michal's patch computes.
>
> Nice. :-)
>
> Could we perhaps add your proof to the Michal's patch as a comment,
> for reference?
No, thanks. It only proves that it is equivalent to old code, but says
nothing about quality of code, and we really do not want to keep old
code around.
Pavel
--
teflon -- maybe it is a trademark, but it should not be.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Michal Schmidt <xschmi00@stud.feec.vutbr.cz>,
linux-pm@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [linux-pm] [PATCH] swsusp: simpler calculation of number of pages in PBE list
Date: Sat, 30 Jul 2005 15:13:56 +0200 [thread overview]
Message-ID: <20050730131356.GE1830@elf.ucw.cz> (raw)
In-Reply-To: <200507301516.32003.rjw@sisk.pl>
Hi!
> > px >= n + x
> >
> > or
> >
> > (p-1)x >= n
> >
> > or
> >
> > x >= n / (p-1).
> >
> > The obvious solution is
> >
> > x = ceiling(n / (p-1)),
> >
> > so calc_nr should return n + ceiling(n / (p-1)), which is exactly what
> > Michal's patch computes.
>
> Nice. :-)
>
> Could we perhaps add your proof to the Michal's patch as a comment,
> for reference?
No, thanks. It only proves that it is equivalent to old code, but says
nothing about quality of code, and we really do not want to keep old
code around.
Pavel
--
teflon -- maybe it is a trademark, but it should not be.
next prev parent reply other threads:[~2005-07-30 13:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-29 19:46 [PATCH] swsusp: simpler calculation of number of pages in PBE list Michal Schmidt
2005-07-29 19:46 ` Michal Schmidt
2005-07-29 20:43 ` Rafael J. Wysocki
2005-07-29 20:43 ` [linux-pm] " Rafael J. Wysocki
2005-07-29 21:14 ` Michal Schmidt
2005-07-29 21:14 ` [linux-pm] " Michal Schmidt
2005-07-29 21:53 ` Rafael J. Wysocki
2005-07-29 21:53 ` [linux-pm] " Rafael J. Wysocki
2005-07-30 1:35 ` Alan Stern
2005-07-30 1:35 ` [linux-pm] " Alan Stern
2005-07-30 13:16 ` Rafael J. Wysocki
2005-07-30 13:16 ` [linux-pm] " Rafael J. Wysocki
2005-07-30 13:13 ` Pavel Machek [this message]
2005-07-30 13:13 ` Pavel Machek
2005-07-30 13:32 ` Rafael J. Wysocki
2005-07-30 13:32 ` [linux-pm] " Rafael J. Wysocki
2005-07-30 14:37 ` Alan Stern
2005-07-30 14:37 ` [linux-pm] " Alan Stern
2005-07-30 13:20 ` Pavel Machek
2005-07-30 13:20 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2005-07-30 13:33 Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050730131356.GE1830@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=rjw@sisk.pl \
--cc=xschmi00@stud.feec.vutbr.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.