From: Dave Jones <davej@redhat.com>
To: Rolf Eike Beer <eike@sf-mail.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Saripalli, Venkata Ramanamurthy (STSD)" <saripalli@hp.com>,
linux-scsi@vger.kernel.org, axboe@suse.de
Subject: Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel
Date: Thu, 4 Aug 2005 13:38:56 -0400 [thread overview]
Message-ID: <20050804173856.GG22886@redhat.com> (raw)
In-Reply-To: <200508041911.46911@bilbo.math.uni-mannheim.de>
On Thu, Aug 04, 2005 at 07:11:38PM +0200, Rolf Eike Beer wrote:
> >It's pointless to fix this, without fixing also CpqTsGetSFQEntry()
> At least half of the file should be rewritten.
Just half ? You're such an optimist :-)
> > > No, ulDestPtr ist ULONG* so we increase it by sizeof(ULONG)*16 which is
> > > 64.
> >Duh, yes. That is broken on 64-bit however, where it will advance 128 bytes
> >instead of 64 bytes.
>
> ULONG is defined to __u32 in some of the cpq* headers.
Ewwwww.
Ok, definitly time to stop reading.
Dave
next prev parent reply other threads:[~2005-08-04 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-04 4:39 [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel Saripalli, Venkata Ramanamurthy (STSD)
2005-08-04 4:39 ` Saripalli, Venkata Ramanamurthy (STSD)
2005-08-04 4:49 ` Dave Jones
2005-08-04 9:38 ` Rolf Eike Beer
2005-08-04 12:13 ` Denis Vlasenko
2005-08-04 15:40 ` Dave Jones
2005-08-04 15:56 ` Rolf Eike Beer
2005-08-04 16:42 ` Dave Jones
2005-08-04 17:11 ` Rolf Eike Beer
2005-08-04 17:38 ` Dave Jones [this message]
2005-08-04 13:53 ` Jesper Juhl
2005-08-06 1:13 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050804173856.GG22886@redhat.com \
--to=davej@redhat.com \
--cc=axboe@suse.de \
--cc=eike@sf-mail.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=saripalli@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.