* [PATCH] remove linux/pagemap.h from linux/swap.h
@ 2005-08-06 16:27 ` Olaf Hering
0 siblings, 0 replies; 2+ messages in thread
From: Olaf Hering @ 2005-08-06 16:27 UTC (permalink / raw)
To: Andrew Morton, linux-kernel; +Cc: sparclinux, bboissin
sparc can not include linux/pagemap.h because of the following circular
dependency:
asm-sparc/pgtable include linux/swap.h
linux/swap.h include now linux/pagemap.h
linux/pagemap.h include linux/mm.h
linux/mm.h include asm/pgtable.h
It needs to have the swp_entry_t type fully visible in pgtable.h,
we can't work around this using macros.
Signed-off-by: Olaf Hering <olh@suse.de>
include/linux/swap.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6.13-rc5-git3.sparc/include/linux/swap.h
=================================--- linux-2.6.13-rc5-git3.sparc.orig/include/linux/swap.h
+++ linux-2.6.13-rc5-git3.sparc/include/linux/swap.h
@@ -7,7 +7,6 @@
#include <linux/mmzone.h>
#include <linux/list.h>
#include <linux/sched.h>
-#include <linux/pagemap.h>
#include <asm/atomic.h>
#include <asm/page.h>
@@ -255,6 +254,8 @@ static inline void put_swap_token(struct
#define si_swapinfo(val) \
do { (val)->freeswap = (val)->totalswap = 0; } while (0)
+/* only sparc can not include linux/pagemap.h in this file
+ * so leave page_cache_release and release_pages undeclared... */
#define free_page_and_swap_cache(page) \
page_cache_release(page)
#define free_pages_and_swap_cache(pages, nr) \
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] remove linux/pagemap.h from linux/swap.h
@ 2005-08-06 16:27 ` Olaf Hering
0 siblings, 0 replies; 2+ messages in thread
From: Olaf Hering @ 2005-08-06 16:27 UTC (permalink / raw)
To: Andrew Morton, linux-kernel; +Cc: sparclinux, bboissin
sparc can not include linux/pagemap.h because of the following circular
dependency:
asm-sparc/pgtable include linux/swap.h
linux/swap.h include now linux/pagemap.h
linux/pagemap.h include linux/mm.h
linux/mm.h include asm/pgtable.h
It needs to have the swp_entry_t type fully visible in pgtable.h,
we can't work around this using macros.
Signed-off-by: Olaf Hering <olh@suse.de>
include/linux/swap.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6.13-rc5-git3.sparc/include/linux/swap.h
===================================================================
--- linux-2.6.13-rc5-git3.sparc.orig/include/linux/swap.h
+++ linux-2.6.13-rc5-git3.sparc/include/linux/swap.h
@@ -7,7 +7,6 @@
#include <linux/mmzone.h>
#include <linux/list.h>
#include <linux/sched.h>
-#include <linux/pagemap.h>
#include <asm/atomic.h>
#include <asm/page.h>
@@ -255,6 +254,8 @@ static inline void put_swap_token(struct
#define si_swapinfo(val) \
do { (val)->freeswap = (val)->totalswap = 0; } while (0)
+/* only sparc can not include linux/pagemap.h in this file
+ * so leave page_cache_release and release_pages undeclared... */
#define free_page_and_swap_cache(page) \
page_cache_release(page)
#define free_pages_and_swap_cache(pages, nr) \
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-08-06 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-06 16:27 [PATCH] remove linux/pagemap.h from linux/swap.h Olaf Hering
2005-08-06 16:27 ` Olaf Hering
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.