From: Domen Puncer <domen@coderock.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
Date: Sat, 6 Aug 2005 21:12:33 +0200 [thread overview]
Message-ID: <20050806191233.GA7322@homer.coderock.org> (raw)
In-Reply-To: <42EE9C0F.30004@gmail.com>
On 02/08/05 00:02 +0200, Jiri Slaby wrote:
> Hello.
> Could you send me critics and bugs?
You have much bigger chances of someone reviewing the patch if you
at least split code changes and whitespace/type cleanups. 65k is a lot.
> Could somebody test it (but NOT now)?
> Thanks.
>
> drivers/char/isicom.c | 1610
> ++++++++++++++++++++++++-------------------------
> include/linux/isicom.h | 8
> 2 files changed, 817 insertions(+), 801 deletions(-)
>
> Here it is (about 65 KiB):
It should deserve a few bytes of description ;-)
> http://www.fi.muni.cz/~xslaby/lnx/isi.txt
>
next prev parent reply other threads:[~2005-08-06 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 22:02 [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten Jiri Slaby
2005-08-05 23:45 ` Jiri Slaby
2005-08-06 19:12 ` Domen Puncer [this message]
2005-08-07 0:17 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050806191233.GA7322@homer.coderock.org \
--to=domen@coderock.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.