From: Jiri Slaby <jirislaby@gmail.com>
To: Domen Puncer <domen@coderock.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
Date: Sun, 07 Aug 2005 02:17:35 +0200 [thread overview]
Message-ID: <42F5531F.5040704@gmail.com> (raw)
In-Reply-To: <20050806191233.GA7322@homer.coderock.org>
Domen Puncer napsal(a):
>You have much bigger chances of someone reviewing the patch if you
>at least split code changes and whitespace/type cleanups. 65k is a lot.
>
>
Ok, 3 patches:
http://www.fi.muni.cz/~xslaby/lnx/isi_main.txt
this changes many lines of code, adds hotplug, firmware loading, add one
fixme, because i have really no idea, what device feed to
request_firmware when isa card is used
http://www.fi.muni.cz/~xslaby/lnx/isi_us.txt
unsigned short changed to u16 and similar, where it expect sized operands
http://www.fi.muni.cz/~xslaby/lnx/isi_w.txt
changes trying to convert code into CodingStyle
removed trailing spaces, some lines longer than 80 split
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
prev parent reply other threads:[~2005-08-07 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 22:02 [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten Jiri Slaby
2005-08-05 23:45 ` Jiri Slaby
2005-08-06 19:12 ` Domen Puncer
2005-08-07 0:17 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42F5531F.5040704@gmail.com \
--to=jirislaby@gmail.com \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.