From: David Teigland <teigland@redhat.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: Pekka Enberg <penberg@gmail.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-cluster@redhat.com
Subject: Re: GFS
Date: Mon, 8 Aug 2005 19:39:10 +0800 [thread overview]
Message-ID: <20050808113910.GF13951@redhat.com> (raw)
In-Reply-To: <courier.42F73AB3.00006AEE@courier.cs.helsinki.fi>
On Mon, Aug 08, 2005 at 01:57:55PM +0300, Pekka J Enberg wrote:
> David Teigland writes:
> >> but why can't you return NULL here on failure like you do for
> >> find_lock_page()?
> >
> >because create is set
>
> Yes, but looking at (some of the) top-level callers, there's no real reason
> why create must not fail. Am I missing something here?
I'll trace the callers back farther and see about dealing with errors.
> >> gfs2-02.patch:+ RETRY_MALLOC(bd = kmem_cache_alloc(gfs2_bufdata_cachep,
>
> It is passed to the page allocator just like with kmalloc() which uses
> __cache_alloc() too.
Yes, I read it wrongly, looks like NOFAIL should work fine. I think we
can get rid of the RETRY macro entirely.
Thanks,
Dave
next prev parent reply other threads:[~2005-08-08 11:35 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-02 7:18 [PATCH 00/14] GFS David Teigland
2005-08-02 7:45 ` Arjan van de Ven
2005-08-02 14:57 ` Jan Engelhardt
2005-08-02 15:02 ` Arjan van de Ven
2005-08-03 1:00 ` Hans Reiser
2005-08-03 4:07 ` Kyle Moffett
2005-08-03 6:37 ` Jan Engelhardt
2005-08-03 9:09 ` Arjan van de Ven
2005-08-03 3:56 ` David Teigland
2005-08-03 9:17 ` Arjan van de Ven
2005-08-03 10:08 ` David Teigland
2005-08-03 10:37 ` Lars Marowsky-Bree
2005-08-03 18:54 ` Mark Fasheh
2005-08-05 7:14 ` David Teigland
2005-08-05 7:27 ` [Linux-cluster] " Mike Christie
2005-08-05 7:30 ` Mike Christie
2005-08-05 7:34 ` Arjan van de Ven
2005-08-05 9:44 ` David Teigland
2005-08-05 10:07 ` Jörn Engel
2005-08-05 10:31 ` David Teigland
2005-08-05 8:28 ` Jan Engelhardt
2005-08-05 8:34 ` Arjan van de Ven
2005-08-08 6:26 ` David Teigland
2005-08-11 6:06 ` David Teigland
2005-08-11 6:55 ` Arjan van de Ven
2005-08-02 10:16 ` Pekka Enberg
2005-08-03 6:36 ` David Teigland
2005-08-08 14:14 ` GFS Pekka J Enberg
2005-08-08 18:32 ` GFS Zach Brown
2005-08-09 14:49 ` GFS Pekka Enberg
2005-08-09 17:17 ` GFS Zach Brown
2005-08-09 18:35 ` GFS Pekka J Enberg
2005-08-10 4:48 ` GFS Pekka J Enberg
2005-08-10 7:21 ` GFS Christoph Hellwig
2005-08-10 7:31 ` GFS Pekka J Enberg
2005-08-10 16:26 ` GFS Mark Fasheh
2005-08-10 16:57 ` GFS Pekka J Enberg
2005-08-10 18:21 ` GFS Mark Fasheh
2005-08-10 20:18 ` GFS Pekka J Enberg
2005-08-10 22:07 ` GFS Mark Fasheh
2005-08-11 4:41 ` GFS Pekka J Enberg
2005-08-10 5:59 ` GFS David Teigland
2005-08-10 6:06 ` GFS Pekka J Enberg
2005-08-03 6:44 ` [PATCH 00/14] GFS Pekka Enberg
2005-08-08 9:57 ` David Teigland
2005-08-08 10:00 ` GFS Pekka J Enberg
2005-08-08 10:05 ` [PATCH 00/14] GFS Arjan van de Ven
2005-08-08 10:20 ` Jörn Engel
2005-08-08 10:18 ` GFS Pekka J Enberg
2005-08-08 10:56 ` GFS David Teigland
2005-08-08 10:57 ` GFS Pekka J Enberg
2005-08-08 11:39 ` David Teigland [this message]
2005-08-08 10:34 ` GFS Pekka J Enberg
2005-08-09 14:55 ` GFS Pekka J Enberg
2005-08-10 7:40 ` GFS Pekka J Enberg
2005-08-10 7:43 ` GFS Christoph Hellwig
2005-08-09 15:20 ` [PATCH 00/14] GFS Al Viro
2005-08-10 7:03 ` Christoph Hellwig
2005-08-10 10:30 ` Lars Marowsky-Bree
2005-08-10 10:32 ` Christoph Hellwig
2005-08-10 10:34 ` Lars Marowsky-Bree
2005-08-10 10:54 ` Christoph Hellwig
2005-08-10 11:02 ` Lars Marowsky-Bree
2005-08-10 11:05 ` Christoph Hellwig
2005-08-10 11:09 ` Lars Marowsky-Bree
2005-08-10 11:11 ` Christoph Hellwig
2005-08-10 13:26 ` [Linux-cluster] " AJ Lewis
2005-08-10 15:43 ` Kyle Moffett
2005-08-11 8:17 ` GFS - updated patches David Teigland
2005-08-11 8:21 ` [Linux-cluster] " Michael
2005-08-11 8:46 ` David Teigland
2005-08-11 8:49 ` Michael
2005-08-11 8:32 ` Arjan van de Ven
2005-08-11 8:50 ` David Teigland
2005-08-11 8:50 ` Arjan van de Ven
2005-08-11 9:16 ` David Teigland
2005-08-11 10:04 ` Pekka Enberg
2005-08-11 9:54 ` [Linux-cluster] " Michael
2005-08-11 10:00 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2005-08-11 7:10 GFS Pekka J Enberg
2005-08-11 16:33 ` GFS Zach Brown
2005-08-11 16:35 ` GFS Christoph Hellwig
2005-08-11 16:39 ` GFS Zach Brown
2005-08-11 16:44 ` GFS Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050808113910.GF13951@redhat.com \
--to=teigland@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-cluster@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.