Re: w1: more debug level decrease.

Re: w1: more debug level decrease.

[Andi Kleen]

Greg KH <greg@kroah.com> writes:

> Here's a patch for 2.6.13-rc6 to keep people's syslogs a bit nicer.

But why is this thing running every 10 seconds at all in the first place?
Looks to me like you're just hiding the symptoms, not fixing the bug
that makes this code run on unsuspecting systems.

e.g. one way would be to only probe once and then never again. 

-Andi

> 
> From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> 
> Do not spam syslog each 10 seconds when there is nothing on the wire.
> 
> Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> ---
>  drivers/w1/w1.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- gregkh-2.6.orig/drivers/w1/w1.c	2005-08-02 13:41:30.000000000 -0700
> +++ gregkh-2.6/drivers/w1/w1.c	2005-08-12 11:42:04.000000000 -0700
> @@ -593,7 +593,7 @@
>  		 * Return 0 - device(s) present, 1 - no devices present.
>  		 */
>  		if (w1_reset_bus(dev)) {
> -			dev_info(&dev->dev, "No devices present on the wire.\n");
> +			dev_dbg(&dev->dev, "No devices present on the wire.\n");
>  			break;
>  		}
>  
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: w1: more debug level decrease.

[Greg KH]

On Fri, Aug 12, 2005 at 10:16:12PM +0200, Andi Kleen wrote:
> Greg KH <greg@kroah.com> writes:
> 
> > Here's a patch for 2.6.13-rc6 to keep people's syslogs a bit nicer.
> 
> But why is this thing running every 10 seconds at all in the first place?
> Looks to me like you're just hiding the symptoms, not fixing the bug
> that makes this code run on unsuspecting systems.
> 
> e.g. one way would be to only probe once and then never again. 

Don't know, Evgeniy?

greg k-h

Re: w1: more debug level decrease.

[Evgeniy Polyakov]

On Fri, Aug 12, 2005 at 10:16:12PM +0200, Andi Kleen (ak@suse.de) wrote:
> Greg KH <greg@kroah.com> writes:
> 
> > Here's a patch for 2.6.13-rc6 to keep people's syslogs a bit nicer.
> 
> But why is this thing running every 10 seconds at all in the first place?
> Looks to me like you're just hiding the symptoms, not fixing the bug
> that makes this code run on unsuspecting systems.
> 
> e.g. one way would be to only probe once and then never again. 

Hmmm, why do you think it is a bug? :)

This bus does not have any kind of notiication, so w1 core 
searches for devices on this buses and prints when something is found
or not. Exactly because of this message people are unhappy.

> -Andi
> 
> > 
> > From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> > 
> > Do not spam syslog each 10 seconds when there is nothing on the wire.
> > 
> > Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > 
> > ---
> >  drivers/w1/w1.c |    2 +-
> >  1 files changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- gregkh-2.6.orig/drivers/w1/w1.c	2005-08-02 13:41:30.000000000 -0700
> > +++ gregkh-2.6/drivers/w1/w1.c	2005-08-12 11:42:04.000000000 -0700
> > @@ -593,7 +593,7 @@
> >  		 * Return 0 - device(s) present, 1 - no devices present.
> >  		 */
> >  		if (w1_reset_bus(dev)) {
> > -			dev_info(&dev->dev, "No devices present on the wire.\n");
> > +			dev_dbg(&dev->dev, "No devices present on the wire.\n");
> >  			break;
> >  		}
> >  
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/

-- 
	Evgeniy Polyakov

w1: more debug level decrease.

[Greg KH]

Here's a patch for 2.6.13-rc6 to keep people's syslogs a bit nicer.

From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>

Do not spam syslog each 10 seconds when there is nothing on the wire.

Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/w1/w1.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- gregkh-2.6.orig/drivers/w1/w1.c	2005-08-02 13:41:30.000000000 -0700
+++ gregkh-2.6/drivers/w1/w1.c	2005-08-12 11:42:04.000000000 -0700
@@ -593,7 +593,7 @@
 		 * Return 0 - device(s) present, 1 - no devices present.
 		 */
 		if (w1_reset_bus(dev)) {
-			dev_info(&dev->dev, "No devices present on the wire.\n");
+			dev_dbg(&dev->dev, "No devices present on the wire.\n");
 			break;
 		}