All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: zach@vmware.com, akpm@osdl.org, chrisl@vmware.com,
	chrisw@osdl.org, hpa@zytor.com, Keir.Fraser@cl.cam.ac.uk,
	linux-kernel@vger.kernel.org, m+Ian.Pratt@cl.cam.ac.uk,
	mbligh@mbligh.org, pratap@vmware.com,
	virtualization@lists.osdl.org, zwame@arm.linux.org.uk
Subject: Re: [PATCH 4/14] i386 / Clean up asm and volatile keywords in desc
Date: Tue, 16 Aug 2005 16:52:00 -0700	[thread overview]
Message-ID: <20050816235200.GS7762@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050816234205.GE27628@wotan.suse.de>

* Andi Kleen (ak@suse.de) wrote:
> On Wed, Aug 10, 2005 at 09:53:51PM -0700, zach@vmware.com wrote:
> > Stop using extra underscores on asm and volatiles, that is just silly.
> 
> Actually the volatiles might be still useful. Or if you drop them
> at least add memory clobbers.

They are still there, just the underscores on both asm and volatile got
pulled.

> I had sometimes bugs  on x86-64
> with the compiler moving such assembly statements with invisible 
> side effects around too aggressively and causing weird problems.
> 
> Agreed on the underscores, I hate them too :)

Heh, same here ;-)

thanks,
-chris

      parent reply	other threads:[~2005-08-16 23:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-11  4:53 [PATCH 4/14] i386 / Clean up asm and volatile keywords in desc zach
2005-08-16 23:42 ` Andi Kleen
2005-08-16 23:49   ` H. Peter Anvin
2005-08-16 23:52   ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050816235200.GS7762@shell0.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=chrisl@vmware.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m+Ian.Pratt@cl.cam.ac.uk \
    --cc=mbligh@mbligh.org \
    --cc=pratap@vmware.com \
    --cc=virtualization@lists.osdl.org \
    --cc=zach@vmware.com \
    --cc=zwame@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.