From: Ryan Harper <ryanh@us.ibm.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@oss.sgi.com
Subject: Re: Possible race with br_del_if()
Date: Thu, 18 Aug 2005 17:23:23 -0500 [thread overview]
Message-ID: <20050818222323.GI10593@us.ibm.com> (raw)
In-Reply-To: <20050818151202.6fe6ded4@dxpl.pdx.osdl.net>
* Stephen Hemminger <shemminger@osdl.org> [2005-08-18 17:11]:
> On Thu, 18 Aug 2005 16:40:36 -0500
> Ryan Harper <ryanh@us.ibm.com> wrote:
>
> > Hello,
> >
> > I've encountered several oops when adding and removing interfaces from
> > bridges while using Xen. Most of the details are available [1]here.
> > The short of it is the following sequence:
>
> Doesn't the mutex in RTNL work right? or are you calling
> routines with out asserting it?
unregister_netdevice asserts RTNL, add_del_if() in br_ioctl.c doesn't
seem to do so. I don't see it down dev_get_by_index() path either. It
looks like any caller of add_del_if() isn't asserting RTNL. The two
callers I see are:
br_dev_ioctl() in br_ioctl.c
old_dev_ioctl() in br_ioctl.c
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253 T/L: 678-9253
ryanh@us.ibm.com
next prev parent reply other threads:[~2005-08-18 22:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-18 21:40 Possible race with br_del_if() Ryan Harper
2005-08-18 22:12 ` Stephen Hemminger
2005-08-18 22:23 ` Ryan Harper [this message]
2005-08-18 22:35 ` Stephen Hemminger
2005-08-18 22:56 ` Ryan Harper
2005-08-19 19:10 ` Ryan Harper
2005-08-19 19:40 ` Stephen Hemminger
2005-10-11 20:33 ` [PATCH] br: fix race on bridge del if Stephen Hemminger
2005-10-12 22:10 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050818222323.GI10593@us.ibm.com \
--to=ryanh@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.