* s390 build fix.
@ 2005-08-21 4:38 Dave Jones
2005-08-21 5:11 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2005-08-21 4:38 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
{standard input}: Assembler messages:
{standard input}:397: Error: symbol `.Litfits' is already defined
{standard input}:585: Error: symbol `.Litfits' is already defined
Newer gcc's inline this it seems, which blows up.
--- linux-2.6.12/arch/s390/kernel/cpcmd.c~ 2005-08-18 15:12:51.000000000 -0400
+++ linux-2.6.12/arch/s390/kernel/cpcmd.c 2005-08-18 15:13:35.000000000 -0400
@@ -46,9 +46,9 @@ int __cpcmd(const char *cmd, char *resp
"lra 3,0(%4)\n"
"lr 5,%5\n"
"diag 2,4,0x8\n"
- "brc 8, .Litfits\n"
+ "brc 8, .Litfits%=\n"
"ar 5, %5\n"
- ".Litfits: \n"
+ ".Litfits%=: \n"
"lr %0,4\n"
"lr %1,5\n"
: "=d" (return_code), "=d" (return_len)
@@ -64,9 +64,9 @@ int __cpcmd(const char *cmd, char *resp
"sam31\n"
"diag 2,4,0x8\n"
"sam64\n"
- "brc 8, .Litfits\n"
+ "brc 8, .Litfits%=\n"
"agr 5, %5\n"
- ".Litfits: \n"
+ ".Litfits%=: \n"
"lgr %0,4\n"
"lgr %1,5\n"
: "=d" (return_code), "=d" (return_len)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: s390 build fix.
2005-08-21 4:38 s390 build fix Dave Jones
@ 2005-08-21 5:11 ` Al Viro
2005-08-21 5:26 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Al Viro @ 2005-08-21 5:11 UTC (permalink / raw)
To: Dave Jones, linux-kernel, torvalds
On Sun, Aug 21, 2005 at 12:38:39AM -0400, Dave Jones wrote:
> {standard input}: Assembler messages:
> {standard input}:397: Error: symbol `.Litfits' is already defined
> {standard input}:585: Error: symbol `.Litfits' is already defined
>
> Newer gcc's inline this it seems, which blows up.
Eeek... Much easier (and already sent to Linus):
diff -urN RC13-rc6-git2-arm-float/arch/s390/kernel/cpcmd.c RC13-rc6-git2-s390/arch/s390/kernel/cpcmd.c
--- RC13-rc6-git2-arm-float/arch/s390/kernel/cpcmd.c 2005-08-10 10:37:46.000000000 -0400
+++ RC13-rc6-git2-s390/arch/s390/kernel/cpcmd.c 2005-08-10 20:38:56.000000000 -0400
@@ -46,9 +46,9 @@
"lra 3,0(%4)\n"
"lr 5,%5\n"
"diag 2,4,0x8\n"
- "brc 8, .Litfits\n"
+ "brc 8, 1f\n"
"ar 5, %5\n"
- ".Litfits: \n"
+ "1: \n"
"lr %0,4\n"
"lr %1,5\n"
: "=d" (return_code), "=d" (return_len)
@@ -64,9 +64,9 @@
"sam31\n"
"diag 2,4,0x8\n"
"sam64\n"
- "brc 8, .Litfits\n"
+ "brc 8, 1f\n"
"agr 5, %5\n"
- ".Litfits: \n"
+ "1: \n"
"lgr %0,4\n"
"lgr %1,5\n"
: "=d" (return_code), "=d" (return_len)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: s390 build fix.
2005-08-21 5:11 ` Al Viro
@ 2005-08-21 5:26 ` Dave Jones
0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2005-08-21 5:26 UTC (permalink / raw)
To: Al Viro; +Cc: linux-kernel, torvalds
On Sun, Aug 21, 2005 at 06:11:31AM +0100, Al Viro wrote:
> On Sun, Aug 21, 2005 at 12:38:39AM -0400, Dave Jones wrote:
> > {standard input}: Assembler messages:
> > {standard input}:397: Error: symbol `.Litfits' is already defined
> > {standard input}:585: Error: symbol `.Litfits' is already defined
> >
> > Newer gcc's inline this it seems, which blows up.
>
> Eeek... Much easier (and already sent to Linus):
Sure, that works for me too.
Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-08-21 5:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-21 4:38 s390 build fix Dave Jones
2005-08-21 5:11 ` Al Viro
2005-08-21 5:26 ` Dave Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.