From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] const / static (against current CVS)
Date: Wed, 24 Aug 2005 15:49:04 +0100 [thread overview]
Message-ID: <200508241549.04816.paul@codesourcery.com> (raw)
In-Reply-To: <20050824143851.GA24595@rhlx01.fht-esslingen.de>
On Wednesday 24 August 2005 15:38, Andreas Mohr wrote:
> Hi,
>
> On Wed, Aug 24, 2005 at 02:41:44PM +0100, Paul Brook wrote:
> > > Probably more important is to make sure none constant data structures
> > > are done on the stack. There is no good reason why any code page
> > > should be read-write.
> >
> > Huh? this is nonsense.
>
> Uhoh, I seem to have managed to stir up a veritable hornet's net with my
> patch...
For the record this wasn't intended as a criticism of your patch. I think
adding const/static is a good idea for debugging/maintainability, even if it
doesn't give any actual performance benefits.
Paul
next prev parent reply other threads:[~2005-08-24 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 17:40 [Qemu-devel] [PATCH] const / static (against current CVS) Andreas Mohr
2005-08-24 3:24 ` Mulyadi Santosa
2005-08-24 12:54 ` Doctor Bill
2005-08-24 13:41 ` Paul Brook
2005-08-24 14:38 ` Andreas Mohr
2005-08-24 14:49 ` Paul Brook [this message]
2005-08-24 16:49 ` Doctor Bill
2005-08-24 20:35 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508241549.04816.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.