From: Arun Sharma <arun.sharma@intel.com>
To: Ian Pratt <Ian.Pratt@cl.cam.ac.uk>,
Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: [PATCH] Don't put vide in .setup.init section
Date: Wed, 24 Aug 2005 16:19:54 -0700 [thread overview]
Message-ID: <20050824231954.GA9038@intel.com> (raw)
[ Today's xen hung without output on the serial console for us. The
seemingly harmless custom_param() in amd.c broke things on an Intel box :) ]
Don't put vide in .setup.init section
Also, it's safer to test for the case where param > __setup_end due to
some mysterious misalignment.
Signed-off-by: Jun Nakajima <jun.nakajima@intel.com>
Signed-off-by: Arun Sharma <arun.sharma@intel.com>
diff -r fa0754a9f64f -r e2025593f702 xen/arch/x86/cpu/amd.c
--- a/xen/arch/x86/cpu/amd.c Wed Aug 24 20:29:21 2005
+++ b/xen/arch/x86/cpu/amd.c Wed Aug 24 23:16:52 2005
@@ -39,7 +39,7 @@
*/
extern void vide(void);
-__asm__(".align 4\nvide: ret");
+__asm__(".text\n.align 4\nvide: ret");
static void __init init_amd(struct cpuinfo_x86 *c)
{
diff -r fa0754a9f64f -r e2025593f702 xen/common/kernel.c
--- a/xen/common/kernel.c Wed Aug 24 20:29:21 2005
+++ b/xen/common/kernel.c Wed Aug 24 23:16:52 2005
@@ -46,7 +46,7 @@
if ( optval != NULL )
*optval++ = '\0';
- for ( param = &__setup_start; param != &__setup_end; param++ )
+ for ( param = &__setup_start; param <= &__setup_end; param++ )
{
if ( strcmp(param->name, opt ) != 0 )
continue;
reply other threads:[~2005-08-24 23:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050824231954.GA9038@intel.com \
--to=arun.sharma@intel.com \
--cc=Ian.Pratt@cl.cam.ac.uk \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.