All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Don't put vide in .setup.init section
@ 2005-08-24 23:19 Arun Sharma
  0 siblings, 0 replies; only message in thread
From: Arun Sharma @ 2005-08-24 23:19 UTC (permalink / raw)
  To: Ian Pratt, Keir Fraser; +Cc: xen-devel

[ Today's xen hung without output on the serial console for us. The
  seemingly harmless custom_param() in amd.c broke things on an Intel box :) ]

Don't put vide in .setup.init section

Also, it's safer to test for the case where param > __setup_end due to
some mysterious misalignment.

Signed-off-by: Jun Nakajima <jun.nakajima@intel.com>
Signed-off-by: Arun Sharma <arun.sharma@intel.com>

diff -r fa0754a9f64f -r e2025593f702 xen/arch/x86/cpu/amd.c
--- a/xen/arch/x86/cpu/amd.c	Wed Aug 24 20:29:21 2005
+++ b/xen/arch/x86/cpu/amd.c	Wed Aug 24 23:16:52 2005
@@ -39,7 +39,7 @@
  */
  
 extern void vide(void);
-__asm__(".align 4\nvide: ret");
+__asm__(".text\n.align 4\nvide: ret");
 
 static void __init init_amd(struct cpuinfo_x86 *c)
 {
diff -r fa0754a9f64f -r e2025593f702 xen/common/kernel.c
--- a/xen/common/kernel.c	Wed Aug 24 20:29:21 2005
+++ b/xen/common/kernel.c	Wed Aug 24 23:16:52 2005
@@ -46,7 +46,7 @@
         if ( optval != NULL )
             *optval++ = '\0';
 
-        for ( param = &__setup_start; param != &__setup_end; param++ )
+        for ( param = &__setup_start; param <= &__setup_end; param++ )
         {
             if ( strcmp(param->name, opt ) != 0 )
                 continue;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-08-24 23:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-24 23:19 [PATCH] Don't put vide in .setup.init section Arun Sharma

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.