All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [patch] fix a few comments in exec.c
@ 2005-08-27 12:28 Bernhard Fischer
  0 siblings, 0 replies; only message in thread
From: Bernhard Fischer @ 2005-08-27 12:28 UTC (permalink / raw)
  To: qemu-devel

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

Hi,

	* exec.c: (cpu_physical_memory_rw): fix comments and trim some
	whitespace while at it.

Please apply.

thank you,
Bernhard

[-- Attachment #2: qemu.cow-20050827-1420.diff --]
[-- Type: text/plain, Size: 3007 bytes --]

diff -X excl -rduNp qemu.oorig/exec.c qemu/exec.c
--- qemu.oorig/exec.c	2005-08-23 19:58:48.000000000 +0200
+++ qemu/exec.c	2005-08-27 14:18:31.000000000 +0200
@@ -2167,7 +2167,7 @@ void stl_phys(target_phys_addr_t addr, u
 }
 
 #else
-void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, 
+void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf,
                             int len, int is_write)
 {
     int l, io_index;
@@ -2176,7 +2176,7 @@ void cpu_physical_memory_rw(target_phys_
     target_phys_addr_t page;
     unsigned long pd;
     PhysPageDesc *p;
-    
+
     while (len > 0) {
         page = addr & TARGET_PAGE_MASK;
         l = (page + TARGET_PAGE_SIZE) - addr;
@@ -2188,22 +2188,22 @@ void cpu_physical_memory_rw(target_phys_
         } else {
             pd = p->phys_offset;
         }
-        
+
         if (is_write) {
             if ((pd & ~TARGET_PAGE_MASK) != IO_MEM_RAM) {
                 io_index = (pd >> IO_MEM_SHIFT) & (IO_MEM_NB_ENTRIES - 1);
                 if (l >= 4 && ((addr & 3) == 0)) {
-                    /* 32 bit read access */
+                    /* 32 bit write access */
                     val = ldl_p(buf);
                     io_mem_write[io_index][2](io_mem_opaque[io_index], addr, val);
                     l = 4;
                 } else if (l >= 2 && ((addr & 1) == 0)) {
-                    /* 16 bit read access */
+                    /* 16 bit write access */
                     val = lduw_p(buf);
                     io_mem_write[io_index][1](io_mem_opaque[io_index], addr, val);
                     l = 2;
                 } else {
-                    /* 8 bit access */
+                    /* 8 bit write access */
                     val = ldub_p(buf);
                     io_mem_write[io_index][0](io_mem_opaque[io_index], addr, val);
                     l = 1;
@@ -2218,7 +2218,7 @@ void cpu_physical_memory_rw(target_phys_
                     /* invalidate code */
                     tb_invalidate_phys_page_range(addr1, addr1 + l, 0);
                     /* set dirty bit */
-                    phys_ram_dirty[addr1 >> TARGET_PAGE_BITS] |= 
+                    phys_ram_dirty[addr1 >> TARGET_PAGE_BITS] |=
                         (0xff & ~CODE_DIRTY_FLAG);
                 }
             }
@@ -2237,14 +2237,14 @@ void cpu_physical_memory_rw(target_phys_
                     stw_p(buf, val);
                     l = 2;
                 } else {
-                    /* 8 bit access */
+                    /* 8 bit read access */
                     val = io_mem_read[io_index][0](io_mem_opaque[io_index], addr);
                     stb_p(buf, val);
                     l = 1;
                 }
             } else {
                 /* RAM case */
-                ptr = phys_ram_base + (pd & TARGET_PAGE_MASK) + 
+                ptr = phys_ram_base + (pd & TARGET_PAGE_MASK) +
                     (addr & ~TARGET_PAGE_MASK);
                 memcpy(buf, ptr, l);
             }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-08-27 12:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-27 12:28 [Qemu-devel] [patch] fix a few comments in exec.c Bernhard Fischer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.