[PATCH] drivers/net/s2io.h - lvalue fix

[PATCH] drivers/net/s2io.h - lvalue fix

[Stephane Wirtel]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Hi all , 

Sorry if I don't send this patch to the maintainer of s2io, but I don't
know who is he.

This patch is based on Kernel 2.6.13 release from the Linus tree.

Is there a process to send patch to the mailing list ?

Best regards, 

Stephane

-- 
Stephane Wirtel <stephane.wirtel@belgacom.net>
                <stephane.wirtel@gmail.com>



[-- Attachment #2: patch_lvalue_s2io.diff --]
[-- Type: text/plain, Size: 310 bytes --]

diff --git a/drivers/net/s2io.h b/drivers/net/s2io.h
--- a/drivers/net/s2io.h
+++ b/drivers/net/s2io.h
@@ -762,8 +762,8 @@ static inline u64 readq(void __iomem *ad
 {
 	u64 ret = 0;
 	ret = readl(addr + 4);
-	(u64) ret <<= 32;
-	(u64) ret |= readl(addr);
+	ret <<= 32;
+	ret |= readl(addr);
 
 	return ret;
 }

Re: [PATCH] drivers/net/s2io.h - lvalue fix

[Jesper Juhl]

On 8/30/05, Stephane Wirtel <stephane.wirtel@belgacom.net> wrote:
> Hi all ,
> 
> Sorry if I don't send this patch to the maintainer of s2io, but I don't
> know who is he.
> 
Hmm, neither do I. Looking in MAINTAINERS I don't see anybody, and
looking in the sources I find just a company name `Neterion'.
So, lacking an email address for a maintainer, sending your patch to
linux-kernel is the right thing to do (even if you had found a
maintainer, adding linux-kernel to Cc: would usually also be proper).
If you get no response at all from the list or maintainer, then Andrew
Morton is the head 2.6 maintainer.


> This patch is based on Kernel 2.6.13 release from the Linus tree.
> 
> Is there a process to send patch to the mailing list ?
> 

Check out 
   - Documentation/SubmittingPatches
   - http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
   - http://linux.yyz.us/patch-format.html
   - http://www.tux.org/lkml/#s1-10
   - http://www.tux.org/lkml/#s1-15


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: [PATCH] drivers/net/s2io.h - lvalue fix

[Stephane Wirtel]

Hi Jesper, 
> Hmm, neither do I. Looking in MAINTAINERS I don't see anybody, and
> looking in the sources I find just a company name `Neterion'.
> So, lacking an email address for a maintainer, sending your patch to
> linux-kernel is the right thing to do (even if you had found a
> maintainer, adding linux-kernel to Cc: would usually also be proper).
> If you get no response at all from the list or maintainer, then Andrew
> Morton is the head 2.6 maintainer.
Ok, thanks for your response.
> 
> 
> > This patch is based on Kernel 2.6.13 release from the Linus tree.
> > 
> > Is there a process to send patch to the mailing list ?
> > 
> 
> Check out 
>    - Documentation/SubmittingPatches
>    - http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
>    - http://linux.yyz.us/patch-format.html
>    - http://www.tux.org/lkml/#s1-10
>    - http://www.tux.org/lkml/#s1-15
Thanks

Best Regards, 

Stephane

-- 
Stephane Wirtel <stephane.wirtel@belgacom.net>
                <stephane.wirtel@gmail.com>

Re: [PATCH] drivers/net/s2io.h - lvalue fix

[Alexey Dobriyan]

On Tue, Aug 30, 2005 at 01:07:25AM +0200, Stephane Wirtel wrote:
> > Hmm, neither do I. Looking in MAINTAINERS I don't see anybody, and
> > looking in the sources I find just a company name `Neterion'.
> > So, lacking an email address for a maintainer, sending your patch to
> > linux-kernel is the right thing to do (even if you had found a
> > maintainer, adding linux-kernel to Cc: would usually also be proper).
> > If you get no response at all from the list or maintainer, then Andrew
> > Morton is the head 2.6 maintainer.
> Ok, thanks for your response.

s2io is a network driver, so Cc'ing netdev@ should be enough.