Re: [PATCH 2/3] CLUSTERIP: introduce reference counting for entries

[KOVACS Krisztian <hidden@balabit.hu>]

  Hi,

On Tuesday 30 August 2005 16.07, Harald Welte wrote:
> Thanks for your patches 2 and 3.  I want to review them in more
> detail and need to re-read the CLUSTERIP code first.  Expect some
> feedback in the next two days.

  OK, thanks. BTW, I've just found a serious bug in patch 2, I knew I
was missing something... So please apply this on top of patch 2.

Index: linux-2.6.13/net/ipv4/netfilter/ipt_CLUSTERIP.c
===================================================================
--- linux-2.6.13.orig/net/ipv4/netfilter/ipt_CLUSTERIP.c	2005-08-30 
16:59:07.702210333 +0200
+++ linux-2.6.13/net/ipv4/netfilter/ipt_CLUSTERIP.c	2005-08-30 
16:50:27.431088379 +0200
@@ -444,6 +444,7 @@
 	 * attached, simply increase the entry refcount and return */
 	if (cipinfo->config != NULL) {
 		clusterip_config_entry_get(cipinfo->config);
+                clusterip_config_get(cipinfo->config);
 		return 1;
 	}

-- 
 Regards,
  Krisztian Kovacs